-
Notifications
You must be signed in to change notification settings - Fork 1
Soundings in plot #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soundings in plot #123
Conversation
but scales are not converting from domain to pixel, it stays domain Refs #68
I also don't understand this, but I did manage to get points rendered by adding 273.15 to temperature values as the scale is in Kelvin but data in Celcius. Now we still need to convert from actual temperature to potential temperature, and other conversions for other plots. Raw temperature can be plotted directly on skewT though. I'll work on that now. |
|
Data format now includes all sounding data from CSV example file, and it is converted on CLASS side. We might want to exclude wind speed/direction and consider only accepting |
|
@sverhoeven can you check this again? |
sverhoeven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When hovering over line makes a extra line appear just next to the hovered line.
| <AxisBottom domain={xLim} label={analysis.variable} /> | ||
| <AxisLeft domain={yLim} label="Height[m]" /> | ||
| <For each={profileData()}>{(d) => Line(d)}</For> | ||
| <For each={observations()}>{(d) => Line(d)}</For> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why show as a dotted line?
This gives the impression that each dot is an observation event.
Also rendering as dotted line makes it look like second experiment (which is also a dotted line)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do this as part of #110 (comment)
Will check locally for remaining issues with optional vs required name Co-authored-by: Stefan Verhoeven <[email protected]>
#124 we can change this to lighter color or so, but keeping the linewidth intact. |

Refs #68
TODO
Timeseries(not possible)