Skip to content

Conversation

@sverhoeven
Copy link
Collaborator

@sverhoeven sverhoeven commented Apr 3, 2025

Refs #68

TODO

  • able to upload with observations see apps/class-solid/tests/config-with-observations.json for example
  • render observations in plots
    • Vertical plot
      • temp
      • humid
    • Timeseries (not possible)
    • Thermodynamic diagram

@Peter9192
Copy link
Member

but scales are not converting from domain to pixel, it stays domain

I also don't understand this, but I did manage to get points rendered by adding 273.15 to temperature values as the scale is in Kelvin but data in Celcius. Now we still need to convert from actual temperature to potential temperature, and other conversions for other plots. Raw temperature can be plotted directly on skewT though. I'll work on that now.

@Peter9192
Copy link
Member

This looks about right I think:

image

@Peter9192
Copy link
Member

Data format now includes all sounding data from CSV example file, and it is converted on CLASS side. We might want to exclude wind speed/direction and consider only accepting q and Td instead of calculating them from RH.

@Peter9192
Copy link
Member

@sverhoeven can you check this again?

@Peter9192 Peter9192 marked this pull request as ready for review April 4, 2025 14:06
Copy link
Collaborator Author

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When hovering over line makes a extra line appear just next to the hovered line.

<AxisBottom domain={xLim} label={analysis.variable} />
<AxisLeft domain={yLim} label="Height[m]" />
<For each={profileData()}>{(d) => Line(d)}</For>
<For each={observations()}>{(d) => Line(d)}</For>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why show as a dotted line?

This gives the impression that each dot is an observation event.

Also rendering as dotted line makes it look like second experiment (which is also a dotted line)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do this as part of #110 (comment)

Peter9192 and others added 3 commits April 8, 2025 09:57
Will check locally for remaining issues with optional vs required name

Co-authored-by: Stefan Verhoeven <[email protected]>
@Peter9192
Copy link
Member

When hovering over line makes a extra line appear just next to the hovered line.

#124 we can change this to lighter color or so, but keeping the linewidth intact.

@Peter9192 Peter9192 merged commit c97cba9 into main Apr 8, 2025
4 checks passed
@Peter9192 Peter9192 deleted the 68-soundings-in-plot branch April 8, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants