Restyle permutations #128
Merged
Restyle permutations #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also replace border around permutations with white space
To make it harder to delete permutation by accident
Peter9192
reviewed
Apr 10, 2025
Member
Peter9192
left a comment
Peter9192
left a comment
There was a problem hiding this comment.
I took the liberty of adding some tweaks to the experiment card, please have another look :-)
| </DropdownMenuItem> | ||
| <DropdownMenuItem onSelect={() => setOpenEditDialog(true)}> | ||
| <MdiCog /> | ||
| Edit permutation |
Member
There was a problem hiding this comment.
I think edit will be the most used action, so perhaps put that one on top here?
| <MdiMenu /> | ||
| {props.perm.name} | ||
| </DropdownMenuTrigger> | ||
| <DropdownMenuContent> |
Member
There was a problem hiding this comment.
I think I would prefer to left-align this
| <DropdownMenuContent> | ||
| <DropdownMenuItem onSelect={() => setOpenDifferenceDialog(true)}> | ||
| <MdiLightVectorDifference /> | ||
| View differences with reference configuration |
Member
There was a problem hiding this comment.
class="flex gap-2" on the parent gives slightly nicer spacing imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
