Skip to content

Conversation

@Peter9192
Copy link
Member

@Peter9192 Peter9192 commented Apr 11, 2025

Adding padding and zoom effect

  • Zoom (assuming axes extent is fixed / constant aspect ratio)
    • Towards mouse (nice-to-have, optional)
  • Pan
    • linear
    • smooth
    • log
  • Reset plot button

note: f085554 resets axis on variable change, this should probably be in this PR, but there's a few commits in between.

Closes #115

@Peter9192
Copy link
Member Author

Also tested in production build.

@Peter9192 Peter9192 marked this pull request as ready for review April 18, 2025 08:40
@Peter9192 Peter9192 requested a review from sverhoeven April 18, 2025 08:40
@Peter9192 Peter9192 mentioned this pull request Apr 22, 2025
5 tasks
Copy link
Collaborator

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm.

I replaced the reset plot icon with something more commonly used.
I added grabby hand cursor so the user get feedback what they can do.
In Chrome when panning text was being selected, I fixed this.

How reset zoom button is wired to plot is a bit hacky, would be nicer if this was contained in an analysis card.

This PR fixes #115m do not forget to close it.

@sverhoeven
Copy link
Collaborator

Given default example and zooming into time series and then changing the runtime to 3600. The timeseries plot retains it zoom/pan so plot is empty. Would be nice to reset plot when plot axes range depends on user input.

@Peter9192 Peter9192 merged commit cea0f0c into main Apr 24, 2025
4 checks passed
@Peter9192 Peter9192 deleted the pan-zoom branch April 24, 2025 13:23
@Peter9192
Copy link
Member Author

Given default example and zooming into time series and then changing the runtime to 3600. The timeseries plot retains it zoom/pan so plot is empty. Would be nice to reset plot when plot axes range depends on user input.

Good catch, I opened #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zoom / pan option is missing

3 participants