-
Notifications
You must be signed in to change notification settings - Fork 1
Pan zoom #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…use real axis extent rather than fixes base/top pressure
… they don't tilt anymore
|
Also tested in production build. |
sverhoeven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm.
I replaced the reset plot icon with something more commonly used.
I added grabby hand cursor so the user get feedback what they can do.
In Chrome when panning text was being selected, I fixed this.
How reset zoom button is wired to plot is a bit hacky, would be nicer if this was contained in an analysis card.
This PR fixes #115m do not forget to close it.
|
Given default example and zooming into time series and then changing the runtime to 3600. The timeseries plot retains it zoom/pan so plot is empty. Would be nice to reset plot when plot axes range depends on user input. |
Good catch, I opened #150 |
Adding padding and zoom effect
note: f085554 resets axis on variable change, this should probably be in this PR, but there's a few commits in between.
Closes #115