make form less fragile #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As unwrap sometimes returns proxy object which structuredClone cannot handle. Refs #150
Peter9192
approved these changes
Apr 17, 2025
Member
Peter9192
left a comment
Peter9192
left a comment
There was a problem hiding this comment.
Seems to fix issue indeed. Did you want to add a build preview GH action?
This reverts commit 719a371.
sverhoeven
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131
To test
pnpm build cd apps/class-solid pnpm startThen try to get
Uncaught client exceptionto appear by opening and closing the edit form of experiment and permutations, if you can not then the issue is fixed.