Skip to content

Some more layout tweaks #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Peter9192 merged 18 commits into from
Apr 24, 2025
Merged

Some more layout tweaks #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
15b1562
Implement basic zoom; TODO: fix angle in skewT
Peter9192 Apr 11, 2025
4b9625c
Add logarithmic zoom for skew-T diagram; TODO: T calculations should …
Peter9192 Apr 11, 2025
89f028b
Fix skew-T lines responding to original extent instead of actual; now…
Peter9192 Apr 11, 2025
8e29a5a
Add panning effect, but it is stroboscopic and doesn't work for skewT…
Peter9192 Apr 11, 2025
53f2cb1
combine side-effects for both axes in a single callback
Peter9192 Apr 11, 2025
23f4dae
Merge remote-tracking branch 'origin/main' into pan-zoom
Peter9192 Apr 18, 2025
ca46f1f
Remove animationframe
Peter9192 Apr 18, 2025
8be9635
Use produce to update both scales in a single call
Peter9192 Apr 18, 2025
859557b
Don't update panstart; this fixes the jittering
Peter9192 Apr 18, 2025
9c32384
Also work in log space
Peter9192 Apr 18, 2025
d3fae43
Make consistent for x-direction
Peter9192 Apr 18, 2025
ea696fc
zoom towards cursor
Peter9192 Apr 18, 2025
b65f516
Add reset plot button
Peter9192 Apr 18, 2025
69e93d4
Thinner lines
Peter9192 Apr 18, 2025
1ca0f68
Higher resolution plot
Peter9192 Apr 18, 2025
8953c43
Round time to steps of 10 minutes
Peter9192 Apr 18, 2025
7055176
Merge remote-tracking branch 'origin/main' into layout
Peter9192 Apr 24, 2025
6166321
format fix
Peter9192 Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/class-solid/src/components/Analysis.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export function TimeSeriesPlot({ analysis }: { analysis: TimeseriesAnalysis }) {
e.output ? e.output[analysis.yVariable] : [],
);

const xLim = () => getNiceAxisLimits(allX());
const xLim = () => getNiceAxisLimits(allX(), 0, 600);
const yLim = () => getNiceAxisLimits(allY());

const chartData = () =>
Expand Down Expand Up @@ -418,8 +418,9 @@ async function takeScreenshot(event: MouseEvent, analyse: Analysis) {
return;
}

// TODO Make screenshot bigger than the original?
const scale = 1;
// Make screenshot bigger than the original
const scale = 10;

// Can not use toSvg as legend is written in HTML
// generated svg document contains foreignObject with html tag
// which can only be rendered using web browser, not Inkscape or PowerPoint
Expand Down
3 changes: 2 additions & 1 deletion apps/class-solid/src/components/plots/Axes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ export const AxisLeft = (props: AxisProps) => {
export function getNiceAxisLimits(
data: number[],
extraMargin = 0,
roundTo?: number, // Optional rounding step, e.g. 600 for 10 minutes
): [number, number] {
const max = Math.max(...data);
const min = Math.min(...data);
Expand All @@ -87,7 +88,7 @@ export function getNiceAxisLimits(
// Avoid NaNs on axis for constant values
if (range === 0) return [min - 1, max + 1];

const step = 10 ** Math.floor(Math.log10(range));
const step = roundTo ?? 10 ** Math.floor(Math.log10(range));

const niceMin = Math.floor(min / step) * step - extraMargin * step;
const niceMax = Math.ceil(max / step) * step + extraMargin * step;
Expand Down
2 changes: 1 addition & 1 deletion apps/class-solid/src/components/plots/Line.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function Line(d: ChartData<Point>) {
fill="none"
stroke={stroke()}
stroke-dasharray={d.linestyle}
stroke-width="3"
stroke-width="2"
d={l(d.data) || ""}
class="cursor-pointer"
>
Expand Down
4 changes: 2 additions & 2 deletions apps/class-solid/src/components/plots/skewTlogP.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ function Sounding(data: ChartData<SoundingRecord>) {
clip-path="url(#clipper)"
stroke={stroke()}
stroke-dasharray={data.linestyle}
stroke-width={3}
stroke-width={2}
fill="none"
class="cursor-pointer"
>
Expand All @@ -133,7 +133,7 @@ function Sounding(data: ChartData<SoundingRecord>) {
clip-path="url(#clipper)"
stroke={stroke()}
stroke-dasharray="5,5"
stroke-width={3}
stroke-width={2}
fill="none"
class="cursor-pointer"
>
Expand Down