Skip to content

Conversation

@Peter9192
Copy link
Member

@Peter9192 Peter9192 commented Dec 13, 2024

Add time slider for profile plot(s)

TODO:

  • Also for skew-T
  • Make sure limits don't change during sliding
    • But could use a slightly more sophisticated approach, accounting for the inversion in the extents.
  • Make sure time points from all experiments are condensed into one timeOptions array
    • Can now combine multiple experiments with different times. Only if output is available for selected time, the experiment will be visible.
  • Refactor plot styles?
    • Also use in other plot types
  • Refactor profile plot?

image

@Peter9192 Peter9192 changed the base branch from main to variable-picker December 13, 2024 20:00
Copy link
Collaborator

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice slider even works smoothly with parameter sweep permutations.

With this addition the configure button on an analysis card having a popup makes less sense. We should change it into a toggle button that hides/shows the variable select(s) and time slider or just remove the configure button.

Given default experiment, then the time slider is at 12:00. If I then change the total run time to 28800 (8h) then the plot line is missing and the slider is too big.
localhost_3000_ (7)
Selecting the slider makes it pop to 08:00
You need to sprinkle in some reactivity so that the slider reacts to updated output.

Given 2 experiments with total run time of 28800 and 43200. when sliding past >8h then first line disappears from plot. This is good and expected.

@Peter9192 Peter9192 mentioned this pull request Jan 9, 2025
6 tasks
@Peter9192
Copy link
Member Author

Given default experiment, then the time slider is at 12:00. If I then change the total run time to 28800 (8h) then the plot line is missing and the slider is too big.

That was a tricky one! Good catch.

@Peter9192 Peter9192 marked this pull request as ready for review January 10, 2025 14:48
Base automatically changed from variable-picker to main January 10, 2025 14:49
@Peter9192 Peter9192 merged commit 0c51d7d into main Jan 13, 2025
4 checks passed
@Peter9192 Peter9192 deleted the time-slider branch January 13, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants