Skip to content

Conversation

@hanneskuettner
Copy link

Summary

Migrate ESLint from v8 (legacy .eslintrc.js) to v9 flat config with co-located package config and make use of a single workspace eslint.config.js.

Before this PR it looks like no lint actually ran?

Changes:

  • Upgrade ESLint 8 to 9 with flat config format
  • Remove the @dnd-kit/eslint-config package (configs were broken/missing which might be the reason why no proper lint ran)
  • Add co-located eslint.config.js files in packages that need custom rules
    • Since previously no linting took place I have started with the most relaxed configurations possible to not include additional noise in this PR and make sure the lint passes as-is. If we want we can tackle a couple of the currently ignored rules and make some improvements
  • Create shared React config at config/eslint/react.config.js for reuse across react and stories package
  • Move eslint plugins to package.json files where they're actually used and remove eslint from individual packages
  • Use --flag v10_config_lookup_from_file for proper config resolution per package (this can be removed as soon as it stabilized in eslint v10

Structure:

  • Root config: strict TypeScript rules shared by all packages
  • Package configs: extend root + add package-specific relaxations as warnings
  • Framework configs: pure (don't import root), composed by packages as needed (will be able to add vue, svelte etc)

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2025

⚠️ No Changeset found

Latest commit: f02b131

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 13, 2025

Open in StackBlitz

@dnd-kit/abstract

npm i https://pkg.pr.new/clauderic/dnd-kit/@dnd-kit/abstract@1848

@dnd-kit/collision

npm i https://pkg.pr.new/clauderic/dnd-kit/@dnd-kit/collision@1848

@dnd-kit/dom

npm i https://pkg.pr.new/clauderic/dnd-kit/@dnd-kit/dom@1848

@dnd-kit/geometry

npm i https://pkg.pr.new/clauderic/dnd-kit/@dnd-kit/geometry@1848

@dnd-kit/helpers

npm i https://pkg.pr.new/clauderic/dnd-kit/@dnd-kit/helpers@1848

@dnd-kit/react

npm i https://pkg.pr.new/clauderic/dnd-kit/@dnd-kit/react@1848

@dnd-kit/state

npm i https://pkg.pr.new/clauderic/dnd-kit/@dnd-kit/state@1848

commit: f02b131

Comment on lines +66 to +67
"@dnd-kit/abstract": "^0.1.21",
"@dnd-kit/geometry": "^0.1.21",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't worked with bun a lot, is this normal that these are bumped now in the lock file? I would have expected them to use the workspace protocol and automatically get back-filled on release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant