Add no-handler-update command-line option to omit updating the handler on Lambda#239
Open
aarsilv wants to merge 1 commit intoclaudiajs:masterfrom
Open
Add no-handler-update command-line option to omit updating the handler on Lambda#239aarsilv wants to merge 1 commit intoclaudiajs:masterfrom
aarsilv wants to merge 1 commit intoclaudiajs:masterfrom
Conversation
* add no-handler-update option to omit updating the handler on lambda * get rid of extra newline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new option,
--no-handler-updatewhich omits updating the handler on Lambda.The use case that prompted this PR is we deploy using Claudia, but have a Datadog layer. Thus Claudia's validation needs to use one handler,
lib/lambda.handler, while the Lambda configuration needs to point the the Datadog wrapper handler,/opt/nodejs/node_modules/datadog-lambda-js/handler.handler. With this new command line argument we are able to satisfy the above withclaudia update --handler="lib/lambda.handler" --no-handler-updateWhile testing, I also discovered that the AWS API returns
Statewith a capital "S", while Claudia was looking for lower-case. I adjusted this to match the response so that existing tests passed instead of failed.Should fix: #226