fix: reduce snowplow telemetry timeout from 5s to 1s#2
Open
fix: reduce snowplow telemetry timeout from 5s to 1s#2
Conversation
…labs#12746) * Ensure that alias in dbt_project.yml check are checked with plus prefix * add changie
* fix: suppress stacktrace when snapshot validation fails Catches ValidationError in the CLI postflight decorator alongside DbtException, so users see just the error message instead of a full stacktrace when snapshots are missing required configuration. Fixes dbt-labs#12692 * fix: import order and changelog format --------- Co-authored-by: chinar-amrutkar <chinar-amrutkar@users.noreply.github.com>
claygeo
force-pushed
the
fix/snowplow-quick-connection-timeout
branch
3 times, most recently
from
16bdeb8 to
6905e64
Compare
Co-authored-by: fa-assistant <77991023+fa-assistant@users.noreply.github.com>
* add tracking for catalog count * add catalog_type tracking * add changie * fix failing ut * fix type hints
An unreachable snowplow collector previously stalled dbt for up to 5s (or longer if the underlying TCP stack held the connection open) at the end of every invocation. Reduce both the POST and GET timeouts in TimeoutEmitter to 1s so the failure is near-instant for users with no internet access or a firewalled collector endpoint. Closes dbt-labs#9989
claygeo
force-pushed
the
fix/snowplow-quick-connection-timeout
branch
from
6905e64 to
5751f0e
Compare
Addresses review feedback: - Remove leftover <<<<<<< HEAD conflict marker in test_tracking.py - Remove duplicate changelog YAML (the original Fixes-20260329 entry already covers this change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes dbt-labs#9989
An unreachable snowplow collector previously stalled dbt for up to several seconds (or longer when the underlying TCP stack holds the connection open past the application timeout) at the end of every invocation.
Reduces both the
POSTandGETtimeouts inTimeoutEmitterfrom5.0to1.0seconds so the failure is near-instant for users with no internet access or a firewalled collector endpoint.Test plan
python -m pytest tests/unit/test_tracking.py -v— 7 tests passTestTimeoutEmitterverify both HTTP methods use a timeout ≤ 2sdbt run— should exit within ~1s of the last model finishing rather than hanging 5+ seconds