Open
Conversation
dbt clone ran silently — no per-model START or result output. Users had no
way to tell which models were cloned vs no-ops, or which failed, until the
summary at the end.
Adds before_execute/after_execute implementations to CloneRunner following
the same pattern as ModelRunner: fires LogStartLine at start and
LogModelResult at finish, showing the adapter response ("CREATE TABLE") or
"No-op" when the relation was already current.
Closes dbt-labs#9501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes dbt-labs#9501
dbt cloneran completely silent — no per-model output, no way to tell which models were being cloned vs skipped as no-ops, and no visibility into errors until the end-of-run summary.This adds
before_execute/after_executeimplementations toCloneRunnerfollowing the same pattern asModelRunner:CREATE TABLE) when a clone was createdNo-opwhen the relation already matched the sourceERRORlevel when cloning failedBefore:
After:
Test plan
python -m pytest tests/unit/task/test_clone.py -v— 5 tests passdbt clone --state ./prod-artifactsand verify per-model output appears