Add scaling factor for timeline, custom render popup function, prop documentation#13
Open
brianweiner wants to merge 3 commits intoclayrisser:masterfrom
Open
Add scaling factor for timeline, custom render popup function, prop documentation#13brianweiner wants to merge 3 commits intoclayrisser:masterfrom
brianweiner wants to merge 3 commits intoclayrisser:masterfrom
Conversation
Owner
|
Could you separate the documentation into a separate pull request? |
brianweiner
force-pushed
the
add-scaling-factor-for-timeline
branch
from
19564fe to
3aa2455
Compare
Contributor
Author
|
Sure np #14 |
Owner
|
It might be a week before I finally get to review this |
Owner
|
Thanks for the prop documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cool library! We needed something that displayed in a gantt-like manner without any actual management behaviors.
I took a shot at documenting the props. I was going to add another column for defaults / examples, but thought maybe you'd have some comments first.
We needed custom messaging for the popup, I added a renderPopup prop for GanttRow so we could pass a curried function in that let us combine row-specific details into the rendered message. We thought maybe this would be useful for other users as well.
Also had some issues with the calculated # of ticks -- I ended up just using a simple scaling factor to increase the # that was calculated.
You won't offend me if you reject :)