Re-enable Biome lint rules disabled during migration (#1503)

Author: JamieMagee

app.js

@@ -243,8 +243,7 @@ function createApp(config) {
     } else {
       // Don't log Azure robot liveness checks
       // https://feedback.azure.com/forums/169385-web-apps/suggestions/32120617-document-healthcheck-url-requirement-for-custom-co
-      if (!(request && request.url && request.url.includes('robots933456.txt')))
-        logger.error('SvcRequestFailure: ' + request.url, error)
+      if (!request?.url?.includes('robots933456.txt')) logger.error(`SvcRequestFailure: ${request.url}`, error)
 
       // set locals, only providing error in development
       response.locals.message = error.message

bin/config.js

@@ -34,7 +34,7 @@ function loadFactory(spec, namespace) {
  */
 function loadOne(spec, namespace) {
   const [requirePath, objectPath] = spec.split('|')
-  const getPath = (namespace ? namespace + '.' : '') + requirePath
+  const getPath = (namespace ? `${namespace}.` : '') + requirePath
   let target = get(providers, getPath)
   try {
     if (!target) target = require(requirePath)

biome.json

@@ -30,12 +30,8 @@
       "recommended": true,
       "suspicious": {
         "noAssignInExpressions": "off",
-        "noDoubleEquals": "off",
-        "noGlobalIsNan": "off",
         "noExplicitAny": "off",
         "noDuplicateTestHooks": "off",
-        "noConfusingVoidType": "off",
-        "noMisleadingInstantiator": "off",
         "noConsole": { "level": "off", "options": { "allow": ["log"] } },
         "noVar": "off",
         "useIterableCallbackReturn": "off"
@@ -47,23 +43,13 @@
       },
       "style": {
         "noParameterAssign": "off",
-        "noUselessElse": "off",
-        "useNodejsImportProtocol": "off",
-        "useTemplate": "off",
-        "useDefaultParameterLast": "off",
-        "useSingleVarDeclarator": "off"
+        "useDefaultParameterLast": "off"
       },
       "complexity": {
-        "noForEach": "off",
         "noStaticOnlyClass": "off",
-        "noThisInStatic": "off",
-        "noUselessConstructor": "off",
-        "noUselessTernary": "off",
-        "useOptionalChain": "off",
         "useLiteralKeys": "off"
       },
       "performance": {
-        "noAccumulatingSpread": "off",
         "noDelete": "off"
       }
     }

business/aggregator.js

@@ -73,13 +73,13 @@ class AggregationService {
     const order = this.workingPrecedence || []
     /** @type {string[]} */
     const tools = []
-    order.forEach(tool => {
+    for (const tool of order) {
       const data = this._findData(tool, summarized)
       if (data) {
         tools.push(data.toolSpec)
         mergeDefinitions(result, data.summary)
       }
-    })
+    }
     if (!tools.length) return null
     set(result, 'described.tools', tools.reverse())
     const cdSummarized = this._findData('clearlydefined', summarized)

business/definitionService.d.ts

@@ -385,7 +385,7 @@ export declare class DefinitionService {
    *
    * @param coordinates - Individual or array of coordinates to invalidate
    */
-  invalidate(coordinates: EntityCoordinates | EntityCoordinates[]): Promise<void[]>
+  invalidate(coordinates: EntityCoordinates | EntityCoordinates[]): Promise<undefined[]>
 
   /**
    * Compute and store a definition, then trigger auto-curation
@@ -440,7 +440,7 @@ export declare class DefinitionService {
    * @param mode - 'definitions' to recompute, 'index' to just re-index
    * @param coordinatesList - Optional list of coordinates to reload
    */
-  reload(mode: 'definitions' | 'index', coordinatesList?: string[] | null): Promise<(void | null)[]>
+  reload(mode: 'definitions' | 'index', coordinatesList?: string[] | null): Promise<(undefined | null)[]>
 
   /**
    * Check if a file is in the core facet

business/definitionService.js

@@ -528,10 +528,10 @@ class DefinitionService {
    * @private
    */
   _ensureNoNulls(object) {
-    Object.keys(object).forEach(key => {
+    for (const key of Object.keys(object)) {
       if (object[key] && typeof object[key] === 'object') this._ensureNoNulls(object[key])
       else if (object[key] == null) delete object[key]
-    })
+    }
   }
 
   /**
@@ -713,7 +713,7 @@ class DefinitionService {
     if (declared) referencedExpressions.add(declared)
     /** @type {Set<string>} */
     const result = new Set()
-    referencedExpressions.forEach(expression => this._extractLicensesFromExpression(expression, result))
+    for (const expression of referencedExpressions) this._extractLicensesFromExpression(expression, result)
     return Array.from(result)
   }
 
@@ -726,9 +726,9 @@ class DefinitionService {
   _collectLicenseTexts(definition) {
     /** @type {Set<string>} */
     const result = new Set()
-    definition.files
-      .filter(DefinitionService._isLicenseFile)
-      .forEach(file => this._extractLicensesFromExpression(file.license, result))
+    for (const file of definition.files.filter(DefinitionService._isLicenseFile)) {
+      this._extractLicensesFromExpression(file.license, result)
+    }
     return Array.from(result)
   }
 

lib/condaRepoAccess.js

@@ -121,14 +121,14 @@ class CondaRepoAccess {
     const subdirs = subdir === '-' ? channelData.packages[name].subdirs : [subdir]
     for (const subdir of subdirs) {
       const repoData = await this.fetchRepoData(channel, subdir)
-      ;['packages', 'packages.conda'].forEach(key => {
+      for (const key of ['packages', 'packages.conda']) {
         if (repoData[key]) {
           const matchingVersions = Object.entries(repoData[key])
             .filter(([, packageData]) => packageData.name === name)
             .map(([, packageData]) => `${subdir}:${packageData.version}-${packageData.build}`)
           revisions.push(...matchingVersions)
         }
-      })
+      }
     }
     return uniq(revisions)
   }

lib/curation.js

@@ -106,38 +106,32 @@ class Curation {
     /** @type {string[]} */
     const errors = []
 
-    Object.keys(revisions)
-      .filter(revision => revisions[revision].licensed)
-      .forEach(revision =>
-        sourceLicenseList.push({
-          source: `${revision} licensed.declared`,
-          license: revisions[revision].licensed.declared
-        })
-      )
-
-    Object.keys(revisions)
-      .filter(revision => revisions[revision].files)
-      .forEach(revision => {
-        revisions[revision].files.forEach(
-          /** @param {import('./curation').CurationFileEntry} file */ file => {
-            if (file.license) {
-              sourceLicenseList.push({
-                source: `${file.path} in ${revision} files`,
-                license: file.license
-              })
-            }
-          }
-        )
+    for (const revision of Object.keys(revisions).filter(revision => revisions[revision].licensed)) {
+      sourceLicenseList.push({
+        source: `${revision} licensed.declared`,
+        license: revisions[revision].licensed.declared
       })
+    }
+
+    for (const revision of Object.keys(revisions).filter(revision => revisions[revision].files)) {
+      for (const /** @type {import('./curation').CurationFileEntry} */ file of revisions[revision].files) {
+        if (file.license) {
+          sourceLicenseList.push({
+            source: `${file.path} in ${revision} files`,
+            license: file.license
+          })
+        }
+      }
+    }
 
-    sourceLicenseList.forEach(({ source, license }) => {
+    for (const { source, license } of sourceLicenseList) {
       const parsed = SPDX.normalize(license)
       if (!parsed || parsed.includes('NOASSERTION')) {
         errors.push(`${source} with value "${license}" is not SPDX compliant`)
       } else if (parsed !== license) {
         errors.push(`${source} with value "${license}" is not normalized. Suggest using "${parsed}"`)
       }
-    })
+    }
 
     return {
       isCompliant: errors.length === 0,

lib/entityCoordinates.js

@@ -86,9 +86,9 @@ class EntityCoordinates {
    */
   constructor(type, provider, namespace, name, revision) {
     /** @type {string | undefined} The Type of the entity */
-    this.type = type && type.toLowerCase()
+    this.type = type?.toLowerCase()
     /** @type {string | undefined} The Provider of the entity */
-    this.provider = provider && provider.toLowerCase()
+    this.provider = provider?.toLowerCase()
     /** @type {string | undefined} The Namespace of the entity */
     if (namespace && namespace !== '-') this.namespace = normalize(namespace, this.provider, NAMESPACE)
     /** @type {string | undefined} The Name of the entity */

lib/github.js

@@ -26,7 +26,7 @@ module.exports = {
   getClient: options => {
     const config = {
       headers: defaultHeaders,
-      ...(options && options.token ? { auth: options.token } : {})
+      ...(options?.token ? { auth: options.token } : {})
     }
 
     const github = new Octokit(config)