Skip to content

update to node 24 packages #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamieMagee merged 4 commits into from
Jan 14, 2026
Merged

update to node 24 packages #1366

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b376364
update node packages to 24 and supported docker images
brettfo Dec 18, 2025
98f125b
fix formatting for package.json
brettfo Jan 7, 2026
6667917
Merge branch 'master' into node-24
qtomlinson Jan 14, 2026
aea38d0
Merge branch 'master' into node-24
JamieMagee Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DevDockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright (c) Microsoft Corporation and others. Licensed under the MIT license.
# SPDX-License-Identifier: MIT

FROM docker.io/library/node:24-bullseye
FROM docker.io/library/node:24-trixie
ENV APPDIR=/opt/service

## get SSH server running
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright (c) Microsoft Corporation and others. Licensed under the MIT license.
# SPDX-License-Identifier: MIT

FROM docker.io/library/node:24-bullseye
FROM docker.io/library/node:24-trixie
ENV APPDIR=/opt/service

## get SSH server running
Expand Down
23 changes: 18 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"winston": "^3.17.0"
},
"devDependencies": {
"@tsconfig/node20": "20.1.6",
"@tsconfig/node24": "24.0.2",
"@tsconfig/strictest": "2.0.5",
"@types/base-64": "0.1.3",
"@types/body-parser": "1.19.6",
Expand Down Expand Up @@ -125,4 +125,4 @@
"testcontainers": "^11.2.1",
"typescript": "5.8.3"
}
}
}
7 changes: 5 additions & 2 deletions test/providers/store/mongoDefinitionPagination.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,11 @@ const shouldPaginateSearchCorrectly = function () {
})

after('cleanup database', async function () {
await mongoStore.collection.drop()
await mongoStore.close()
if (mongoStore) {
await mongoStore.collection.drop()
Copy link
Contributor Author

@brettfo brettfo Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found during some local testing that the before() function didn't always complete before after() which would mean the variable mongoStore was still undefined and this line would throw.

await mongoStore.close()
}

await mongoServer.stop()
})

Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": ["@tsconfig/strictest/tsconfig.json", "@tsconfig/node20/tsconfig.json"],
"extends": ["@tsconfig/strictest/tsconfig.json", "@tsconfig/node24/tsconfig.json"],
"compilerOptions": {
"allowJs": true,
"checkJs": true,
Expand Down
Loading