Skip to content

Fix shell injection vulnerability in environment variable handling #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ColeMurray wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix shell injection vulnerability in environment variable handling #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions clearml_session/interactive_session_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import base64
import json
import os
import shlex
import shutil
import socket
import subprocess
Expand Down Expand Up @@ -1028,8 +1029,9 @@ def setup_user_env(param, task):

elif os.environ.get("CLEARML_AUTH_TOKEN"):
env['CLEARML_AUTH_TOKEN'] = os.environ.get("CLEARML_AUTH_TOKEN")
os.system("echo 'export CLEARML_AUTH_TOKEN=\"{}\"' >> {}".format(
os.environ.get("CLEARML_AUTH_TOKEN").replace('$', '\\$'), source_conf))
with open(os.path.expanduser(source_conf), 'a') as f:
f.write('export CLEARML_AUTH_TOKEN={}\n'.format(
shlex.quote(os.environ.get("CLEARML_AUTH_TOKEN"))))

if param.get("default_docker"):
os.system("echo 'export CLEARML_DOCKER_IMAGE=\"{}\"' >> {}".format(
Expand Down