[Bug] Missing "Album artist-album" French translation#203
Draft
remjg wants to merge 1 commit intoclementine-player:masterfrom
Draft
[Bug] Missing "Album artist-album" French translation#203remjg wants to merge 1 commit intoclementine-player:masterfrom
remjg wants to merge 1 commit intoclementine-player:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In French, on of the
pref_library_grouping_valuestranslation is missing, the one foralbumartist-album.Hence, the options don't correspond to the correct grouping features of the library, and the last option is also missing.
Looking at the
/app/src/main/res/values/array.xmlfile, there should be 7 options in the following order :I think that this problem is present in others languages too where I can only see 6 options. Not sure my pull request answer the issue completely, I have never looked into how translations work.