fix encodings when creating TagLib items#7254
Open
Ralino wants to merge 1 commit intoclementine-player:masterfrom
Open
fix encodings when creating TagLib items#7254Ralino wants to merge 1 commit intoclementine-player:masterfrom
Ralino wants to merge 1 commit intoclementine-player:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When given a std::string or a c-string, TagLib interprets it as Latin1 per default. Clementine uses utf8 however.
While the function
StdStringToTaglibStringis used for most tags, it was not used when creatingTagLib::StringListfor other items. This lead to issue #7253This PR fixes that.