build: remove bad double negative when discovering 'git'#7342
Open
muggenhor wants to merge 1 commit intoclementine-player:masterfrom
Open
build: remove bad double negative when discovering 'git'#7342muggenhor wants to merge 1 commit intoclementine-player:masterfrom
muggenhor wants to merge 1 commit intoclementine-player:masterfrom
Conversation
hatstand
force-pushed
the
build/fix-git-check
branch
from
4c79885 to
7d09106
Compare
Contributor
|
This automatically works because CMake's `if` statement considers variables which' content ends with "-NOTFOUND" to be FALSE. The previous version however was first tried as a variable which didn't exist. As a result after that it's interpreted as a string (not a variable anymore). So it skips the "-NOTFOUND" check and only does a "string not empty" check. Which, as this is a string constant, is always true.
hatstand
force-pushed
the
build/fix-git-check
branch
from
7d09106 to
a30f865
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This automatically works because CMake's
ifstatement considers variables which' content ends with "-NOTFOUND" to be FALSE.The previous version however was first tried as a variable which didn't exist. As a result after that it's interpreted as a string (not a variable anymore). So it skips the "-NOTFOUND" check and only does a "string not empty" check. Which, as this is a string constant, is always true.
Of course this only fixes the check. It doesn't address the fact that the remaining code below depends on
GIT_REVhaving some content. So maybe insteadfind_programshould be called with theREQUIREDflag?