Skip to content

Filter tracks by length with tokens similar to lastplayed etc. #7413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hatstand merged 3 commits into from
Oct 3, 2025
+37 −23
Merged

Filter tracks by length with tokens similar to lastplayed etc. #7413

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1823f8
Filter tracks by length with tokens similar to lastplayed etc.
residuum Sep 7, 2025
843aa00
Code cleanup as suggested.
residuum Sep 10, 2025
6ccf43b
Get constants from somewhere else, if available.
residuum Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 37 additions & 23 deletions src/library/libraryquery.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ const QMap<QString, Song::FileType> kFiletypeId = QMap<QString, Song::FileType>(
{"stream", Song::Type_Stream},
{"unknown", Song::Type_Unknown}});

const int kNsecsPerSec = 1e9;
Copy link
Contributor

@hatstand hatstand Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These constants already exist somewhere in Clementine

Copy link
Contributor Author

@residuum residuum Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info, I did not find it, because it is kNsecPerSec, but could not find kAllowedChars or anything else that defines a value of smhd.

const QString kAllowedChars = "smhd";
const int kSecsPerDay = 60 * 60 * 24;

LibraryQuery::LibraryQuery(const QueryOptions& options)
: include_unavailable_(false), join_with_fts_(false), limit_(-1) {
if (!options.filter().isEmpty()) {
Expand Down Expand Up @@ -105,32 +109,16 @@ LibraryQuery::LibraryQuery(const QueryOptions& options)
if (ok) {
AddWhere(columntoken, doubleVal, op);
}
} else if (columntoken == "length") {
double seconds = GetSecondsFromToken(val);
if (seconds > 0) {
double nanoseconds = seconds * kNsecsPerSec;
AddWhere(columntoken, nanoseconds, op);
}
} else if (columntoken == "filetype") {
AddWhere(columntoken, kFiletypeId[val]);
} else if (Song::kDateColumns.contains(columntoken)) {
int seconds = 0;
QString tmp = "";
QString allowedChars = "smhd";
for (QChar c : val) {
if (c.isDigit()) {
tmp.append(c);
} else if (allowedChars.contains(c)) {
bool ok;
int intVal = tmp.toInt(&ok);
tmp = "";
if (ok) {
if (c == 's') {
seconds += intVal;
} else if (c == 'm') {
seconds += intVal * 60;
} else if (c == 'h') {
seconds += intVal * 60 * 60;
} else if (c == 'd') {
seconds += intVal * 60 * 60 * 24;
}
}
}
}
int seconds = GetSecondsFromToken(val);
if (seconds > 0) {
int now = QDateTime::currentDateTime().toTime_t();
QString dt = QString("(%1-%2)").arg(now).arg(columntoken);
Expand Down Expand Up @@ -181,6 +169,32 @@ LibraryQuery::LibraryQuery(const QueryOptions& options)
}
}

int LibraryQuery::GetSecondsFromToken(QString& val) const {
int seconds = 0;
QString tmp = "";
for (QChar c : val) {
if (c.isDigit()) {
tmp.append(c);
} else if (kAllowedChars.contains(c)) {
bool ok = false;
int intVal = tmp.toInt(&ok);
tmp = "";
if (ok) {
if (c == 's') {
seconds += intVal;
} else if (c == 'm') {
seconds += intVal * 60;
} else if (c == 'h') {
seconds += intVal * 60 * 60;
} else if (c == 'd') {
seconds += intVal * kSecsPerDay;
}
}
}
}
return seconds;
}

QString LibraryQuery::GetInnerQuery() {
return duplicates_only_
? QString(
Expand Down
1 change: 1 addition & 0 deletions src/library/libraryquery.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ class LibraryQuery {
static const QStringList kNumericCompOperators;

private:
int GetSecondsFromToken(QString& val) const;
QString GetInnerQuery();

bool include_unavailable_;
Expand Down