Update KGlobalAccel shortcut backend for Plasma 6.5#7419
Open
acidiclight wants to merge 1 commit intoclementine-player:masterfrom
Open
Update KGlobalAccel shortcut backend for Plasma 6.5#7419acidiclight wants to merge 1 commit intoclementine-player:masterfrom
acidiclight wants to merge 1 commit intoclementine-player:masterfrom
Conversation
This commit updates the D-Bus interface and global shortcut backend for kglobalaccel. KDE Frameworks 6.19.0 and Plasma 6.5 added a separate signal for shortcut key repeat events, which breaks Clementine's implementation. Kglobalaccel's previous behaviour was just to send key repeats as normal press events. I decided to just emulate that behaviour. Therefore, I've changed nothing other than connecting to the new signal. Signed-off-by: Ritchie Frodomar <alkalinethunder@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. First time ever contributing here, bear with me!
This PR fixes a bug I'd seen reported on KDE's Bugzilla. Turns out, when we updated kglobalaccel in Frameworks 6.19.0 and kwin in Plasma 6.5, my code may have broken Clementine unintentionally... :(
I've updated the project's D-Bus interface to deal with us separating key repeat from key press events. In most cases, you shouldn't need to do anything special on a key repeat, and since I'm not familiar enough with Clementine's code yet, I opted to just emulate the old behaviour of kglobalaccel from before Frameworks 6.19.
This should have zero effect on older Plasma/kglobalaccel versions.
See also: https://bugs.kde.org/show_bug.cgi?id=511041