Skip to content

Prevent kwargs override on replace #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent kwargs override on replace #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions scrapy_selenium/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,15 @@ def __init__(self, wait_time=None, wait_until=None, screenshot=False, script=Non
self.script = script

super().__init__(*args, **kwargs)

def replace(self, *args, **kwargs):
"""Create a new SeleniumRequest with the same attributes except for those
given new values.
"""
selenium_request_keys = ['wait_time', 'wait_until', 'screenshot', 'script']
scrapy_request_keys = ['url', 'method', 'headers', 'body', 'cookies', 'meta', 'flags',
'encoding', 'priority', 'dont_filter', 'callback', 'errback', 'cb_kwargs']
for x in selenium_request_keys + scrapy_request_keys:
kwargs.setdefault(x, getattr(self, x))
cls = kwargs.pop('cls', self.__class__)
return cls(*args, **kwargs)