Skip to content

Conversation

@CanerKaraca23
Copy link

@CanerKaraca23 CanerKaraca23 commented Jan 20, 2026

  • Update action versions
  • Use latest windows
  • Use stable version of release action

Virustotal results are same:
https://www.virustotal.com/gui/file/ee5dd53060e6d25a24c995089ffb06594572188ca3b41d07ed6f2ca49cbce02b?nocache=1

I have 2 questions also:

In release artifact, Sanny Builder Library json and cleo example files are really needed for basic users? Can we just put them in to SDK artifact?

Should we update Silent's ASI Loader to v1.5?

Copilot AI review requested due to automatic review settings January 20, 2026 01:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Actions workflow configurations to use newer versions of actions and the latest Windows runner environment.

Changes:

  • Updated actions/checkout from v4 to v6 in both test-build.yml and release.yml
  • Updated actions/upload-artifact from v4 to v6 in test-build.yml
  • Changed Windows runner from windows-2022 to windows-latest in both workflows
  • Changed ncipollo/release-action from @main to @v1 for stable releases

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/test-build.yml Updated action versions and Windows runner for test builds
.github/workflows/release.yml Updated action versions and Windows runner for releases, and switched to stable release action version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@x87
Copy link

x87 commented Jan 20, 2026

In release artifact, Sanny Builder Library json and cleo example files are really needed for basic users? Can we just put them in to SDK artifact?

JSON is needed for better error messages.
Examples are optional, but since they are located in cleo_readme folder with changelog and readme, I don't think it hurts anyone to have them included.

@x87
Copy link

x87 commented Jan 20, 2026

Should we update Silent's ASI Loader to v1.5?

I'm on the fence, I like the duplicate ASI detection, which is something CLEO suffered from too, but I'm very skeptical about changing the ASI loading order. It may start a new wave of user reports blaming CLEO for everything.

@x87 x87 added the type:nice-to-have minor enhancements label Jan 20, 2026
@x87
Copy link

x87 commented Jan 20, 2026

One thing we can do, is to use the official GitHub release instead of downloading from Silent's website:
https://github.com/GTAmodding/ASI-Loader/releases/tag/v1.3.0

@CanerKaraca23
Copy link
Author

CanerKaraca23 commented Jan 20, 2026

Should we update Silent's ASI Loader to v1.5?

I'm on the fence, I like the duplicate ASI detection, which is something CLEO suffered from too, but I'm very skeptical about changing the ASI loading order. It may start a new wave of user reports blaming CLEO for everything.

I don't think there will be a "wave", only a few reports may come in.

One thing we can do, is to use the official GitHub release instead of downloading from Silent's website: https://github.com/GTAmodding/ASI-Loader/releases/tag/v1.3.0

I was thinked that for v1.5 too, but there isn't readme and vorbisHooked file to put on the releases. I can update if you put these.

@x87
Copy link

x87 commented Jan 20, 2026

I was thinked that for v1.5 too, but there isn't readme and vorbisHooked file to put on the releases. I can update if you put these.

Ah, you right, those are missed. But I don't want to spend my time on maintaining that repo, not sure how I even got involved into someone else's project.

@CanerKaraca23
Copy link
Author

I was thinked that for v1.5 too, but there isn't readme and vorbisHooked file to put on the releases. I can update if you put these.

Ah, you right, those are missed. But I don't want to spend my time on maintaining that repo, not sure how I even got involved into someone else's project.

I don't think it needs maintaining anymore lol, it's one of the most important project of the mod community, so it's natural to be on GTA modding organization, and you made right and good. Silent and fastman92 have access to update it i believe?

@x87
Copy link

x87 commented Jan 20, 2026

Silent is one of the org members

@CanerKaraca23
Copy link
Author

CanerKaraca23 commented Jan 20, 2026

Okay, i'm leaving it to you, if you decide what to do, you are always be welcomed to edit the PR to update or let me know or simply merge it.

@x87 x87 marked this pull request as draft January 20, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:nice-to-have minor enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants