-
Notifications
You must be signed in to change notification settings - Fork 12
Update Workflows #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update Workflows #494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates GitHub Actions workflow configurations to use newer versions of actions and the latest Windows runner environment.
Changes:
- Updated
actions/checkoutfrom v4 to v6 in both test-build.yml and release.yml - Updated
actions/upload-artifactfrom v4 to v6 in test-build.yml - Changed Windows runner from
windows-2022towindows-latestin both workflows - Changed
ncipollo/release-actionfrom@mainto@v1for stable releases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test-build.yml | Updated action versions and Windows runner for test builds |
| .github/workflows/release.yml | Updated action versions and Windows runner for releases, and switched to stable release action version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JSON is needed for better error messages. |
I'm on the fence, I like the duplicate ASI detection, which is something CLEO suffered from too, but I'm very skeptical about changing the ASI loading order. It may start a new wave of user reports blaming CLEO for everything. |
|
One thing we can do, is to use the official GitHub release instead of downloading from Silent's website: |
I don't think there will be a "wave", only a few reports may come in.
I was thinked that for v1.5 too, but there isn't readme and vorbisHooked file to put on the releases. I can update if you put these. |
Ah, you right, those are missed. But I don't want to spend my time on maintaining that repo, not sure how I even got involved into someone else's project. |
I don't think it needs maintaining anymore lol, it's one of the most important project of the mod community, so it's natural to be on GTA modding organization, and you made right and good. Silent and fastman92 have access to update it i believe? |
|
Silent is one of the org members |
|
Okay, i'm leaving it to you, if you decide what to do, you are always be welcomed to edit the PR to update or let me know or simply merge it. |
Virustotal results are same:
https://www.virustotal.com/gui/file/ee5dd53060e6d25a24c995089ffb06594572188ca3b41d07ed6f2ca49cbce02b?nocache=1
I have 2 questions also:
In release artifact, Sanny Builder Library json and cleo example files are really needed for basic users? Can we just put them in to SDK artifact?
Should we update Silent's ASI Loader to v1.5?