-
Notifications
You must be signed in to change notification settings - Fork 830
React Router SDK: Introduce middleware; update clerkClient usage #2653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@alexisintech @SarahSoutoul what could possibly be my error here? Not able to build on Vercel 👀 |
Hey @wobsoriano - we had the recent restructure of our docs, and your changes included some old paths. Fixed them here: docs review. The deployment is still failing because the Root Auth Loader page is still referencing the root-auth-loader-options hash but you removed that section. I kept it because I wasn't sure if that was on purpose or not. If it is, then that hash needs to be removed for things to pass. ![]() |
@SarahSoutoul yes, that thing isn't needed anymore 🙏🏼 |
@wobsoriano Hmm so do you wanna remove that whole But them, it doesn't make much sense, as like the user might wonder "what configuration options?". |
Reviewed everything. I noticed two things but wanted to check with you both on what you think @alexisintech @wobsoriano:
![]()
![]() |
This is more of a note to self, but we'll need to update the React Router onboarding docs if I'm not mistaken? |
|
agree - duplicate the section with a partial. |
going to work on these action items now! |
now, we just need to add some protect routes examples - @wobsoriano do you mind spinning up these examples? |
🔎 Previews:
What does this solve?
clerkMiddleware()
but will get a warning in the console.clerk/javascript
PR feat(react-router): Introduce middleware and context javascript#6660What changed?
clerkMiddleware()
installation@clerk/react-router/ssr.server
imports to `@clerk/react-router/serverrootAuthLoader()
as it's required to have it in the middleware insteadChecklist