-
Notifications
You must be signed in to change notification settings - Fork 969
core 3: fix email pass custom flow #3036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: core-3
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
My thinking here was that with client trust enabled (which is the default for new instances I believe), signing in with email and password on a new client requires the handling of the |
1dbe98d to
cfac443
Compare
| }) | ||
|
|
||
| await signUp.verifications.sendEmailCode() | ||
| if (!error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is if the user has "verify at sign up" and "email verification code" enabled
they can have email link enabled - will need to think about this

the
email-passwordcustom flow guide doesn't have the copy regarding MFA set up nor explanations of the code added, and its meant to be more for basic usage and users that don't have MFA enabled. if users want to enable MFA, they can go to the appropriate guide, so i've updated the code to point them there