Skip to content

chore(clerk-js): Bump Coinbase sdk version#4945

Merged
panteliselef merged 9 commits intomainfrom
elef/sdki-807-bump-coinbasewallet
Feb 3, 2025
Merged

chore(clerk-js): Bump Coinbase sdk version#4945
panteliselef merged 9 commits intomainfrom
elef/sdki-807-bump-coinbasewallet

Conversation

@panteliselef
Copy link
Contributor

@panteliselef panteliselef commented Jan 20, 2025

Description

Bumps @coinbase/wallet-sdk from 4.0.4 to 4.2.4.
Implements the new way of initializing an instance based on the docs.

Finally, we save approximately 25KB in the lazy loaded bundles.

Vendors chunk

Before After
image image

Coinbase wallet chunk

Before After
image image

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@panteliselef panteliselef requested review from a team, chanioxaris and nikospapcom January 20, 2025 16:36
@panteliselef panteliselef self-assigned this Jan 20, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: 8f45c72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 1:18pm

@panteliselef
Copy link
Contributor Author

I'd like to run a few tests with existing apps to make sure this is safe before merging, so i'm switching to draft for now.

@panteliselef panteliselef marked this pull request as draft January 20, 2025 17:02
Copy link
Member

@chanioxaris chanioxaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you need any help with the test runs

@anagstef
Copy link
Member

!snapshot

@panteliselef
Copy link
Contributor Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 2.2.6-snapshot.v20250203132203
@clerk/clerk-js 5.52.0-snapshot.v20250203132203
@clerk/clerk-expo 2.7.4-snapshot.v20250203132203
@clerk/tanstack-start 0.9.3-snapshot.v20250203132203

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@2.2.6-snapshot.v20250203132203 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.52.0-snapshot.v20250203132203 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.7.4-snapshot.v20250203132203 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.9.3-snapshot.v20250203132203 --save-exact

@panteliselef panteliselef marked this pull request as ready for review February 3, 2025 13:55
Copy link
Member

@tmilewski tmilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good from an remotely-hosted code standpoint, per Browser Extensions. 🚢

@panteliselef panteliselef merged commit f51ecdc into main Feb 3, 2025
27 checks passed
@panteliselef panteliselef deleted the elef/sdki-807-bump-coinbasewallet branch February 3, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants