-
Notifications
You must be signed in to change notification settings - Fork 371
feat(clerk-js): Link to external App page in OAuth Consent #6447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jfoshee
wants to merge
23
commits into
main
Choose a base branch
from
jf.feat/oauth-consent-app-link
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
7e24a6a
feat(clerk-js): Add OAuth Application URL and update Avatar component…
jfoshee 6b70d4f
Merge branch 'main' into jf.feat/oauth-consent-app-link
jfoshee 72e5409
chore: add a task for running dev sandbox
jfoshee 373ded0
support query params for new fields in oauth consent
jfoshee 0cc8f60
Merge branch 'main' into jf.feat/oauth-consent-app-link
jfoshee 8c20482
use spaces in tasks.json
jfoshee d66f708
add changeset
jfoshee b455d85
Merge branch 'main' into jf.feat/oauth-consent-app-link
jfoshee 49283ea
Merge branch 'main' into jf.feat/oauth-consent-app-link
jfoshee efe0820
fix: use <Link> rather than <a>
jfoshee dcfde0e
feat: add Avatar.linkUrl rather than externalLinkUrl
jfoshee e87b640
fix patch notes
jfoshee 92ede1e
fix: missed one
jfoshee 632d779
Merge branch 'main' into jf.feat/oauth-consent-app-link
jfoshee 76c8af4
Merge branch 'main' into jf.feat/oauth-consent-app-link
jfoshee 03576fd
revert changes to avatar
jfoshee d10fb15
style: whitespace
jfoshee 57bff23
Merge branch 'main' into jf.feat/oauth-consent-app-link
jfoshee ecaab41
feat(clerk-js): add `isExternal` to `ApplicationLogo` so users can sa…
jfoshee d437ac9
feat(clerk-js): implement href sanitization to prevent XSS attacks in…
jfoshee b23e967
feedback
jfoshee 038a74a
Merge branch 'main' into jf.feat/oauth-consent-app-link
jfoshee 96dc277
Update sad-turkeys-rhyme.md
jfoshee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
'@clerk/clerk-js': patch | ||
'@clerk/types': patch | ||
--- | ||
|
||
Add optional `linkUrl` to `Avatar` | ||
|
||
Add optional `oAuthApplicationUrl` parameter to OAuth Consent mounting (which is used to provide a link to the OAuth App homepage). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"version": "2.0.0", | ||
"tasks": [ | ||
{ | ||
"type": "npm", | ||
"script": "dev:sandbox", | ||
"path": "packages/clerk-js", | ||
"problemMatcher": [], | ||
"label": "Dev: Sandbox", | ||
"detail": "npm: dev:sandbox - packages/clerk-js" | ||
} | ||
] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.