Skip to content

chore(repo,backend): Add machine-to-machine integration tests #6500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Aug 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nasty-colts-travel.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@clerk/backend": minor
---

Exports `Machine` and `M2MToken` resource classes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Clarify wording and verify “classes” vs “types”; double-check semver level

The body currently says “resource classes,” while the PR summary mentions exporting “types.” Ensure the note matches the actual exports (classes vs types). Also, adding new public exports is often considered a minor release per SemVer, not a patch—confirm if “patch” is intended.

If the intent is generic and accurate regardless of implementation detail, you can update the copy to avoid ambiguity:

-Exports `Machine` and `M2MToken` resource classes
+Expose `Machine` and `M2MToken` as public exports.

Optionally, if this is a minor release:

-"@clerk/backend": patch
+"@clerk/backend": minor

Run this script to verify the nature of the exports and ensure the wording is accurate:


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Checking export statements in packages/backend/src/index.ts..."
rg -n -A2 -B2 'export .* (Machine|M2MToken)' packages/backend/src/index.ts || true

echo
echo "Searching for declarations to determine if they are classes or types..."
rg -n -A2 -B2 'export (class|type|interface) (Machine|M2MToken)' packages/backend/src || true

Length of output: 6239


Update semver to minor for new exports

The term “resource classes” is accurate—both Machine and M2MToken are declared as export class in packages/backend/src/api/resources. However, exposing new public API requires a minor bump, not a patch.

  • .changeset/nasty-colts-travel.md
--- a/.changeset/nasty-colts-travel.md
- "@clerk/backend": patch
+ "@clerk/backend": minor
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Exports `Machine` and `M2MToken` resource classes
---
"@clerk/backend": minor
---
Exports `Machine` and `M2MToken` resource classes
🤖 Prompt for AI Agents
In .changeset/nasty-colts-travel.md around line 5, the changeset currently marks
the package bump as a patch despite adding new exported resource classes; edit
the changeset to change the version bump from "patch" to "minor" (i.e., update
the bump level in the file header or package entry to "minor"), save and commit
the updated changeset so the release tooling will perform a minor version bump.

1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ jobs:
'nuxt',
'react-router',
'billing',
'machine'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

Suggested change
'machine'
'm2m'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there's a follow up PR for this that will group all "machine" related tests (api keys, m2m)

]
test-project: ['chrome']
include:
Expand Down
6 changes: 6 additions & 0 deletions integration/presets/longRunningApps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ export const createLongRunningApps = () => {
{ id: 'withBillingJwtV2.vue.vite', config: vue.vite, env: envs.withBillingJwtV2 },
{ id: 'withBilling.vue.vite', config: vue.vite, env: envs.withBilling },

/**
* Machine auth apps
* TODO(rob): Group other machine auth apps together (api keys, m2m tokens, etc)
*/
{ id: 'withMachine.express.vite', config: express.vite, env: envs.withAPIKeys },

/**
* Vite apps - basic flows
*/
Expand Down
172 changes: 172 additions & 0 deletions integration/tests/machine-auth/m2m.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,172 @@
import { createClerkClient, type M2MToken, type Machine } from '@clerk/backend';
import { faker } from '@faker-js/faker';
import { expect, test } from '@playwright/test';

import type { Application } from '../../models/application';
import { appConfigs } from '../../presets';
import { instanceKeys } from '../../presets/envs';
import { createTestUtils } from '../../testUtils';

test.describe('machine-to-machine auth @machine', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let primaryApiServer: Machine;
let emailServer: Machine;
let analyticsServer: Machine;
let emailServerM2MToken: M2MToken;
let analyticsServerM2MToken: M2MToken;

test.beforeAll(async () => {
const fakeCompanyName = faker.company.name();

// Create primary machine using instance secret key
const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
primaryApiServer = await client.machines.create({
name: `${fakeCompanyName} Primary API Server`,
});

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkClient } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();

app.get('/api/protected', async (req, res) => {
const secret = req.get('Authorization')?.split(' ')[1];

try {
const m2mToken = await clerkClient.m2mTokens.verifySecret({ secret });
res.send('Protected response ' + m2mToken.id);
} catch {
res.status(401).send('Unauthorized');
}
});

const port = parseInt(process.env.PORT as string) || 3002;
ViteExpress.listen(app, port, () => console.log('Server started'));
`,
)
.commit();

await app.setup();

// Using the created machine, set a machine secret key using the primary machine's secret key
const env = appConfigs.envs.withAPIKeys
.clone()
.setEnvVariable('private', 'CLERK_MACHINE_SECRET_KEY', primaryApiServer.secretKey);
await app.withEnv(env);
await app.dev();

// Email server can access primary API server
emailServer = await client.machines.create({
name: `${fakeCompanyName} Email Server`,
scopedMachines: [primaryApiServer.id],
});
emailServerM2MToken = await client.m2mTokens.create({
machineSecretKey: emailServer.secretKey,
secondsUntilExpiration: 60 * 30,
});

// Analytics server cannot access primary API server
analyticsServer = await client.machines.create({
name: `${fakeCompanyName} Analytics Server`,
// No scoped machines
});
analyticsServerM2MToken = await client.m2mTokens.create({
machineSecretKey: analyticsServer.secretKey,
secondsUntilExpiration: 60 * 30,
});
});

test.afterAll(async () => {
const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});

await client.m2mTokens.revoke({
m2mTokenId: emailServerM2MToken.id,
});
await client.m2mTokens.revoke({
m2mTokenId: analyticsServerM2MToken.id,
});
await client.machines.delete(emailServer.id);
await client.machines.delete(primaryApiServer.id);
await client.machines.delete(analyticsServer.id);

await app.teardown();
});

test('rejects requests with invalid M2M tokens', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const res = await u.page.request.get(app.serverUrl + '/api/protected', {
headers: {
Authorization: `Bearer invalid`,
},
});
expect(res.status()).toBe(401);
expect(await res.text()).toBe('Unauthorized');

const res2 = await u.page.request.get(app.serverUrl + '/api/protected', {
headers: {
Authorization: `Bearer mt_xxx`,
},
});
expect(res2.status()).toBe(401);
expect(await res2.text()).toBe('Unauthorized');
});

test('rejects M2M requests when sender machine lacks access to receiver machine', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const res = await u.page.request.get(app.serverUrl + '/api/protected', {
headers: {
Authorization: `Bearer ${analyticsServerM2MToken.secret}`,
},
});
expect(res.status()).toBe(401);
expect(await res.text()).toBe('Unauthorized');
});

test('authorizes M2M requests when sender machine has proper access to receiver machine', async ({
page,
context,
}) => {
const u = createTestUtils({ app, page, context });

// Email server can access primary API server
const res = await u.page.request.get(app.serverUrl + '/api/protected', {
headers: {
Authorization: `Bearer ${emailServerM2MToken.secret}`,
},
});
expect(res.status()).toBe(200);
expect(await res.text()).toBe('Protected response ' + emailServerM2MToken.id);

// Analytics server can access primary API server after adding scope
await u.services.clerk.machines.createScope(analyticsServer.id, primaryApiServer.id);
const m2mToken = await u.services.clerk.m2mTokens.create({
machineSecretKey: analyticsServer.secretKey,
secondsUntilExpiration: 60 * 30,
});

const res2 = await u.page.request.get(app.serverUrl + '/api/protected', {
headers: {
Authorization: `Bearer ${m2mToken.secret}`,
},
});
expect(res2.status()).toBe(200);
expect(await res2.text()).toBe('Protected response ' + m2mToken.id);
await u.services.clerk.m2mTokens.revoke({
m2mTokenId: m2mToken.id,
});
});
});
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"test:integration:generic": "E2E_APP_ID=react.vite.*,next.appRouter.withEmailCodes* pnpm test:integration:base --grep @generic",
"test:integration:handshake": "DISABLE_WEB_SECURITY=true E2E_APP_ID=next.appRouter.sessionsProd1 pnpm test:integration:base --grep @handshake",
"test:integration:localhost": "pnpm test:integration:base --grep @localhost",
"test:integration:machine": "E2E_APP_ID=withMachine.* pnpm test:integration:base --grep @machine",
"test:integration:nextjs": "E2E_APP_ID=next.appRouter.* pnpm test:integration:base --grep @nextjs",
"test:integration:nuxt": "E2E_APP_ID=nuxt.node npm run test:integration:base -- --grep @nuxt",
"test:integration:quickstart": "E2E_APP_ID=quickstart.* pnpm test:integration:base --grep @quickstart",
Expand Down
5 changes: 5 additions & 0 deletions packages/backend/src/api/endpoints/M2MTokenApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ type CreateM2MTokenParams = {
* Custom machine secret key for authentication.
*/
machineSecretKey?: string;
/**
* Number of seconds until the token expires.
*
* @default null - Token does not expire
*/
secondsUntilExpiration?: number | null;
claims?: Record<string, unknown> | null;
};
Expand Down
2 changes: 2 additions & 0 deletions packages/backend/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ export type {
InstanceSettings,
Invitation,
JwtTemplate,
Machine,
M2MToken,
OauthAccessToken,
OAuthApplication,
Organization,
Expand Down
12 changes: 12 additions & 0 deletions turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,18 @@
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
"inputs": ["integration/**"],
"outputLogs": "new-only"
},
"//#test:integration:machine": {
"dependsOn": [
"@clerk/testing#build",
"@clerk/clerk-js#build",
"@clerk/backend#build",
"@clerk/nextjs#build",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are testing against nextjs, right ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to my comment above, the api keys test needs nextjs

"@clerk/express#build"
],
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
"inputs": ["integration/**"],
"outputLogs": "new-only"
}
}
}
Loading