-
Notifications
You must be signed in to change notification settings - Fork 391
feat(clerk-js): Dedupe getToken requests #6891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jacekradko
wants to merge
11
commits into
main
Choose a base branch
from
feat/multitab-poller
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
60a7e8f
feat(clerk-js): Dedupe getToken requests
jacekradko fbbd0c2
Merge branch 'main' into feat/multitab-poller
jacekradko 3139d59
duration based expiration check
jacekradko acf1e78
do not re-broadcast when handling message
jacekradko 38323d5
add new build variant
jacekradko 4f0c799
fix tests
jacekradko 5dcac2a
fix e2e and consolidate clerk-js index files
jacekradko be2b34b
this is not needed
jacekradko fce92f3
Merge branch 'main' into feat/multitab-poller
jacekradko 526153f
Merge branch 'main' into feat/multitab-poller
jacekradko 392cc40
Merge branch 'main' into feat/multitab-poller
jacekradko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// It's crucial this is the first import, | ||
// otherwise chunk loading will not work | ||
// eslint-disable-next-line | ||
import './utils/setWebpackChunkPublicPath'; | ||
|
||
import { Clerk } from './core/clerk'; | ||
|
||
import { mountComponentRenderer } from './ui/Components'; | ||
|
||
Clerk.mountComponentRenderer = mountComponentRenderer; | ||
|
||
const publishableKey = | ||
document.querySelector('script[data-clerk-publishable-key]')?.getAttribute('data-clerk-publishable-key') || | ||
window.__clerk_publishable_key || | ||
''; | ||
|
||
const proxyUrl = | ||
document.querySelector('script[data-clerk-proxy-url]')?.getAttribute('data-clerk-proxy-url') || | ||
window.__clerk_proxy_url || | ||
''; | ||
|
||
const domain = | ||
document.querySelector('script[data-clerk-domain]')?.getAttribute('data-clerk-domain') || window.__clerk_domain || ''; | ||
|
||
// Ensure that if the script has already been injected we don't overwrite the existing Clerk instance. | ||
if (!window.Clerk) { | ||
window.Clerk = new Clerk(publishableKey, { | ||
proxyUrl, | ||
// @ts-expect-error | ||
domain, | ||
}); | ||
} | ||
jacekradko marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
if (module.hot) { | ||
module.hot.accept(); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.