Skip to content

Conversation

dstaley
Copy link
Member

@dstaley dstaley commented Oct 6, 2025

this pr is solely to trigger a pkg pr new release

Summary by CodeRabbit

  • Refactor
    • Updated the sign-in and sign-up hooks to a more responsive implementation, improving UI reactivity during authentication flows.
    • Users may notice smoother state transitions and reduced unnecessary re-renders when signing in or signing up.
    • Existing hook names remain the same; current imports continue to work without changes.
    • This update targets better runtime behavior without altering other authentication hooks or overall app integration.

Copy link

changeset-bot bot commented Oct 6, 2025

⚠️ No Changeset found

Latest commit: 1346d01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Oct 6, 2025 8:56pm

Copy link
Contributor

coderabbitai bot commented Oct 6, 2025

Walkthrough

Re-exports in packages/nextjs/src/client-boundary/hooks.ts now map useSignIn and useSignUp to experimental signal hooks from @clerk/clerk-react/experimental, replacing their previous re-exports from @clerk/clerk-react. No other exports were changed.

Changes

Cohort / File(s) Summary
Hook re-exports
packages/nextjs/src/client-boundary/hooks.ts
Removed useSignIn, useSignUp from the @clerk/clerk-react re-export block; added export { useSignInSignal as useSignIn, useSignUpSignal as useSignUp } from @clerk/clerk-react/experimental, effectively aliasing the experimental signal hooks to the existing names.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant App as App Code
    participant NextHooks as nextjs/src/client-boundary/hooks.ts
    participant ClerkExp as @clerk/clerk-react/experimental

    App->>NextHooks: import { useSignIn, useSignUp }
    Note over NextHooks: Aliases map to signal-based hooks
    NextHooks->>ClerkExp: re-export useSignInSignal as useSignIn
    NextHooks->>ClerkExp: re-export useSignUpSignal as useSignUp
    ClerkExp-->>App: provide signal hook implementations
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit taps the keys with cheer,
Two hooks hop to “signals” here,
Old paths fade, new routes align,
SignIn, SignUp—now redefined.
In fields of code I thump, elated—
Exports mapped, neatly orchestrated. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly highlights the primary change by specifying that the sign-in and sign-up hooks are aliased to their Signal counterparts, directly reflecting the export updates in hooks.ts. It uses a concise conventional commit style prefix and remains readable while conveying the core modification. Although the “[DO NOT MERGE]” marker is extra noise, it does not obscure the essential intent of the change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ds.experiment/nextjs-hooks

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 67bd037 and f873624.

📒 Files selected for processing (1)
  • packages/nextjs/src/client-boundary/hooks.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

**/*.{js,jsx,ts,tsx}: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels

Files:

  • packages/nextjs/src/client-boundary/hooks.ts
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/nextjs/src/client-boundary/hooks.ts
packages/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/nextjs/src/client-boundary/hooks.ts
packages/**/*.{ts,tsx,d.ts}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Packages should export TypeScript types alongside runtime code

Files:

  • packages/nextjs/src/client-boundary/hooks.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Prefer readonly for properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Use const assertions for literal types: as const
Use satisfies operator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports: import type { ... } from ...
No any types without justification
Proper error handling with typed errors
Consistent use of readonly for immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)

Files:

  • packages/nextjs/src/client-boundary/hooks.ts
**/*.{js,ts,tsx,jsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.

Files:

  • packages/nextjs/src/client-boundary/hooks.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: semgrep/ci
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
packages/nextjs/src/client-boundary/hooks.ts (1)

13-13: Breaking change: aliasing experimental hooks to stable names without migration path

  • Consumers of stable useSignIn/useSignUp now receive experimental signal versions with no deprecation warnings, migration guide, or JSDoc marking them as unstable.
  • Exposing experimental APIs under stable names violates semver and risks type/runtime mismatches. Confirm that useSignInSignal/useSignUpSignal exist in your @clerk/clerk-react version and share their TypeScript signatures.

Recommendation: export signal hooks separately or behind a feature flag; deprecate the old hooks with clear warnings and a migration guide before removal in a future major release; add inline documentation and update public docs; verify type compatibility.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

pkg-pr-new bot commented Oct 6, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6930

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6930

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6930

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6930

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6930

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6930

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6930

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6930

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6930

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6930

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6930

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6930

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6930

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6930

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6930

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6930

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6930

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6930

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6930

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6930

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6930

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6930

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6930

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6930

commit: 1346d01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants