Skip to content

chore(ci): update base branch labels for core-2 and core-3#7396

Merged
nikosdouvlis merged 1 commit intomainfrom
nikos/update-labeler
Dec 8, 2025
Merged

chore(ci): update base branch labels for core-2 and core-3#7396
nikosdouvlis merged 1 commit intomainfrom
nikos/update-labeler

Conversation

@nikosdouvlis
Copy link
Member

@nikosdouvlis nikosdouvlis commented Dec 8, 2025

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Updated GitHub workflow label configurations
    • Updated commit message validation rules

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2025

⚠️ No Changeset found

Latest commit: 4ec1f5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Dec 8, 2025 7:02pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 8, 2025

Walkthrough

Updated two configuration files: .github/labeler.yml to reorganize branch-based labels by renaming "core2" to "core-3" and replacing "core3" with "core-2" under a new base-branch, and commitlint.config.ts to add 'ci' as an allowed commit scope.

Changes

Cohort / File(s) Summary
GitHub Labeler Configuration
\.github/labeler\.yml
Replaced "core2" label with "core-3" (base-branch: ^main$); removed "core3" and added "core-2" label (base-branch: ^release/core-2$)
Commit Lint Configuration
commitlint\.config\.ts
Added 'ci' to the allowed commit scopes in the scope-enum rule

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Both files contain straightforward configuration updates with no logic changes or dependencies to verify
  • Label reorganization is clear and self-contained
  • Scope addition follows an existing pattern with no side effects

Poem

🐰 A rabbit hops through configs bright,
Labels dance, renamed just right,
Core-2, core-3, now in place,
CI scopes join the race,
Clean and tidy, what a sight! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: updates to labeler configuration for core-2 and core-3 labels, which aligns with the .github/labeler.yml modifications shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch nikos/update-labeler

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 99dd1b5 and 4ec1f5a.

📒 Files selected for processing (2)
  • .github/labeler.yml (1 hunks)
  • commitlint.config.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (7)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

All code must pass ESLint checks with the project's configuration

Files:

  • commitlint.config.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • commitlint.config.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Follow established naming conventions (PascalCase for components, camelCase for variables)

Files:

  • commitlint.config.ts
**/*.ts?(x)

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

Files:

  • commitlint.config.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details in classes
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like <T extends { id: string }>
Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @param, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Use const assertions with as const for literal types
Use satisfies operator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...

Files:

  • commitlint.config.ts
**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use ESLint with custom configurations tailored for different package types

Files:

  • commitlint.config.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

  • commitlint.config.ts
🧬 Code graph analysis (1)
commitlint.config.ts (1)
scripts/renovate-config-generator.mjs (1)
  • getPackageNames (112-124)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (29)
  • GitHub Check: Unit Tests (shared, clerk-js, RQ)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Unit Tests (**)
  • GitHub Check: Static analysis
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16, RQ)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (2)
commitlint.config.ts (1)

34-34: LGTM! Adding 'ci' scope follows conventional commit standards.

The addition of 'ci' to the allowed commit scopes is appropriate for CI/CD-related changes and aligns with widely accepted conventional commit conventions. This enables the PR's own commit message "chore(ci): ..." to pass linting.

.github/labeler.yml (1)

96-100: Label renaming in labeler.yml is safe and isolated.

The change from "core2"/"core3" to "core-3"/"core-2" improves naming consistency with other hyphenated labels. The "core3" references found in the codebase (package.json, release workflows) refer to the "canary-core3" release channel and branch, which is distinct from GitHub issue/PR label configuration. No conflicts exist between the new hyphenated label names and existing references in the codebase.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 8, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7396

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7396

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7396

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7396

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7396

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7396

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7396

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7396

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7396

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7396

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7396

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7396

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7396

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7396

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7396

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7396

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7396

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7396

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7396

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7396

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7396

commit: 4ec1f5a

@nikosdouvlis nikosdouvlis removed the core2 label Dec 8, 2025
@nikosdouvlis nikosdouvlis merged commit 2b82a6e into main Dec 8, 2025
43 checks passed
@nikosdouvlis nikosdouvlis deleted the nikos/update-labeler branch December 8, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants