fix(shared): use @clerk/ui package version for UI script URL#7418
fix(shared): use @clerk/ui package version for UI script URL#7418nikosdouvlis merged 1 commit intomainfrom
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughIntroduces a new global constant UI_PACKAGE_VERSION sourced from the UI package.json and propagated into TypeScript globals, build definitions, runtime code usage, and test setup; tests and URL construction were updated to use this UI-specific version. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (28)
Comment |
Why this change was needed: The clerkUiScriptUrl function was incorrectly using JS_PACKAGE_VERSION (from @clerk/clerk-js) as the fallback version when no explicit version was provided. This meant @clerk/ui scripts would be loaded using @clerk/clerk-js's version (e.g., @clerk/ui@5) instead of @clerk/ui's own version (e.g., @clerk/ui@0), causing potential version mismatches. What changed: Added UI_PACKAGE_VERSION build constant that reads from @clerk/ui's package.json and updated clerkUiScriptUrl to use it as the fallback instead of JS_PACKAGE_VERSION.
5cfc34e to
62ed71b
Compare
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Why this change was needed:
The clerkUiScriptUrl function was incorrectly using JS_PACKAGE_VERSION (from @clerk/clerk-js) as the fallback version when no explicit version was provided. This meant @clerk/ui scripts would be loaded using @clerk/clerk-js's version (e.g., @clerk/ui@5) instead of @clerk/ui's own version (e.g., @clerk/ui@0), causing potential version mismatches.
What changed:
Added UI_PACKAGE_VERSION build constant that reads from @clerk/ui's package.json and updated clerkUiScriptUrl to use it as the fallback instead of JS_PACKAGE_VERSION.
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.