-
Notifications
You must be signed in to change notification settings - Fork 422
fix(localizations): Update Hebrew localization placeholders for user input fields #7566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
@AryeBorgen is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThis change updates the Hebrew (he-IL) localization resource by replacing six undefined form field placeholder values with their corresponding Hebrew translations. The modifications affect placeholders for email address, first name, last name, organization name, password, and phone number fields. No logic changes or functional alterations were made; this is purely a localization content update. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates Hebrew localization strings by replacing undefined values with Hebrew translations for six user input field placeholders: email address, first name, last name, organization name, password, and phone number.
- Adds Hebrew translations for previously undefined placeholder text
- Provides localized placeholder text for common user input fields
- Improves the user experience for Hebrew-speaking users
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| formFieldInputPlaceholder__emailAddress: 'כתובת האימייל שלך', | ||
| formFieldInputPlaceholder__emailAddress_username: undefined, | ||
| formFieldInputPlaceholder__emailAddresses: '[email protected], [email protected]', | ||
| formFieldInputPlaceholder__firstName: undefined, | ||
| formFieldInputPlaceholder__lastName: undefined, | ||
| formFieldInputPlaceholder__firstName: 'שם פרטי', | ||
| formFieldInputPlaceholder__lastName: 'שם משפחה', | ||
| formFieldInputPlaceholder__organizationDomain: undefined, | ||
| formFieldInputPlaceholder__organizationDomainEmailAddress: undefined, | ||
| formFieldInputPlaceholder__organizationName: undefined, | ||
| formFieldInputPlaceholder__organizationName: 'שם הארגון', | ||
| formFieldInputPlaceholder__organizationSlug: 'הארגון-שלי', | ||
| formFieldInputPlaceholder__password: undefined, | ||
| formFieldInputPlaceholder__phoneNumber: undefined, | ||
| formFieldInputPlaceholder__password: 'הכנס סיסמה', | ||
| formFieldInputPlaceholder__phoneNumber: 'הזן את מספר הטלפון שלך', |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The placeholder translations lack consistency in style. Some use imperative verbs (הכנס, הזן) while others don't, and some include possessive pronouns (שלך) while others omit them. For better user experience, consider applying a consistent pattern across all placeholders. For example, either use imperatives for all (like Spanish "Ingrese su...") or use simple descriptive phrases for all (like "כתובת אימייל", "שם פרטי", etc.).
| formFieldInputPlaceholder__organizationSlug: 'הארגון-שלי', | ||
| formFieldInputPlaceholder__password: undefined, | ||
| formFieldInputPlaceholder__phoneNumber: undefined, | ||
| formFieldInputPlaceholder__password: 'הכנס סיסמה', |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two different Hebrew verbs are used for "enter": "הכנס" (line 224) and "הזן" (line 225). For consistency, use the same verb throughout. "הזן" is more commonly used for data entry in Hebrew UI contexts.
| formFieldInputPlaceholder__password: 'הכנס סיסמה', | |
| formFieldInputPlaceholder__password: 'הזן סיסמה', |
| formFieldInputPlaceholder__backupCode: undefined, | ||
| formFieldInputPlaceholder__confirmDeletionUserAccount: 'מחיקת חשבון', | ||
| formFieldInputPlaceholder__emailAddress: undefined, | ||
| formFieldInputPlaceholder__emailAddress: 'כתובת האימייל שלך', |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word for "email" is inconsistent in the file. Line 215 uses "אימייל" (transliterated), but other parts of the file use 'דוא"ל' (Hebrew acronym for electronic mail, line 237). Consider using the same term consistently throughout the file. The Hebrew acronym 'דוא"ל' is more formal and commonly used in official Israeli contexts.
| formFieldInputPlaceholder__emailAddress: 'כתובת האימייל שלך', | |
| formFieldInputPlaceholder__emailAddress: 'כתובת הדוא"ל שלך', |
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.