Skip to content

Conversation

@AryeDepoint
Copy link

@AryeDepoint AryeDepoint commented Jan 8, 2026

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: Translation

Summary by CodeRabbit

  • Documentation
    • Added Hebrew localization strings for form field placeholders, including email address, first name, last name, organization name, password, and phone number fields, providing proper translations for Hebrew language users.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 8, 2026 19:38
@changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2026

⚠️ No Changeset found

Latest commit: 0355a25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 8, 2026

@AryeBorgen is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026

📝 Walkthrough

Walkthrough

This change updates the Hebrew (he-IL) localization resource by replacing six undefined form field placeholder values with their corresponding Hebrew translations. The modifications affect placeholders for email address, first name, last name, organization name, password, and phone number fields. No logic changes or functional alterations were made; this is purely a localization content update.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: updating Hebrew localization placeholder strings for form input fields.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Hebrew localization strings by replacing undefined values with Hebrew translations for six user input field placeholders: email address, first name, last name, organization name, password, and phone number.

  • Adds Hebrew translations for previously undefined placeholder text
  • Provides localized placeholder text for common user input fields
  • Improves the user experience for Hebrew-speaking users

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +215 to +225
formFieldInputPlaceholder__emailAddress: 'כתובת האימייל שלך',
formFieldInputPlaceholder__emailAddress_username: undefined,
formFieldInputPlaceholder__emailAddresses: '[email protected], [email protected]',
formFieldInputPlaceholder__firstName: undefined,
formFieldInputPlaceholder__lastName: undefined,
formFieldInputPlaceholder__firstName: 'שם פרטי',
formFieldInputPlaceholder__lastName: 'שם משפחה',
formFieldInputPlaceholder__organizationDomain: undefined,
formFieldInputPlaceholder__organizationDomainEmailAddress: undefined,
formFieldInputPlaceholder__organizationName: undefined,
formFieldInputPlaceholder__organizationName: 'שם הארגון',
formFieldInputPlaceholder__organizationSlug: 'הארגון-שלי',
formFieldInputPlaceholder__password: undefined,
formFieldInputPlaceholder__phoneNumber: undefined,
formFieldInputPlaceholder__password: 'הכנס סיסמה',
formFieldInputPlaceholder__phoneNumber: 'הזן את מספר הטלפון שלך',
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placeholder translations lack consistency in style. Some use imperative verbs (הכנס, הזן) while others don't, and some include possessive pronouns (שלך) while others omit them. For better user experience, consider applying a consistent pattern across all placeholders. For example, either use imperatives for all (like Spanish "Ingrese su...") or use simple descriptive phrases for all (like "כתובת אימייל", "שם פרטי", etc.).

Copilot uses AI. Check for mistakes.
formFieldInputPlaceholder__organizationSlug: 'הארגון-שלי',
formFieldInputPlaceholder__password: undefined,
formFieldInputPlaceholder__phoneNumber: undefined,
formFieldInputPlaceholder__password: 'הכנס סיסמה',
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two different Hebrew verbs are used for "enter": "הכנס" (line 224) and "הזן" (line 225). For consistency, use the same verb throughout. "הזן" is more commonly used for data entry in Hebrew UI contexts.

Suggested change
formFieldInputPlaceholder__password: 'הכנס סיסמה',
formFieldInputPlaceholder__password: 'הזן סיסמה',

Copilot uses AI. Check for mistakes.
formFieldInputPlaceholder__backupCode: undefined,
formFieldInputPlaceholder__confirmDeletionUserAccount: 'מחיקת חשבון',
formFieldInputPlaceholder__emailAddress: undefined,
formFieldInputPlaceholder__emailAddress: 'כתובת האימייל שלך',
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word for "email" is inconsistent in the file. Line 215 uses "אימייל" (transliterated), but other parts of the file use 'דוא"ל' (Hebrew acronym for electronic mail, line 237). Consider using the same term consistently throughout the file. The Hebrew acronym 'דוא"ל' is more formal and commonly used in official Israeli contexts.

Suggested change
formFieldInputPlaceholder__emailAddress: 'כתובת האימייל שלך',
formFieldInputPlaceholder__emailAddress: 'כתובת הדוא"ל שלך',

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants