Skip to content

Conversation

@alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Jan 28, 2026

Description

  • removes showLogo from reverification steps
  • removes finger print icon from passkey sign in
BEFORE AFTER
Screenshot 2026-01-28 at 3 05 43 PM Screenshot 2026-01-28 at 3 05 26 PM
Screenshot 2026-01-28 at 2 09 47 PM Screenshot 2026-01-28 at 2 09 17 PM

Resolves USER-4342

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Style
    • Verification screens' headers no longer display the logo.
    • Sign-in header simplified: fingerprint icon removed, now shows title, subtitle, and identity preview only.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jan 28, 2026 8:22pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2026

🦋 Changeset detected

Latest commit: 4b82dff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/ui Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

The PR removes the showLogo prop from Header.Root usages in UVFactorOnePasskeysCard.tsx, UVFactorTwoAlternativeMethods.tsx, UVFactorTwoBackupCodeCard.tsx, and UserVerificationFactorOnePassword.tsx. SignInFactorOnePasskey.tsx was updated to remove the Fingerprint icon and its imports from the header. A new changeset (.changeset/funny-lies-wait.md) indicating a patch for @clerk/ui was added. No other logic, control flow, or public API signatures were modified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: removal of logos from reverification steps, which aligns with the primary objective of the changeset.
Linked Issues check ✅ Passed The changes address the linked issue USER-4342 by removing the showLogo prop from Header.Root in reverification components and the fingerprint icon from passkey sign-in, fulfilling the requirement to remove unexpected logos from the passkey modal.
Out of Scope Changes check ✅ Passed All changes are directly related to the stated objective of removing logos from reverification steps and the passkey sign-in icon, with no unrelated modifications beyond the scope of USER-4342.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • FDB8-4252: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 28, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7692

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7692

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7692

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7692

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7692

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7692

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7692

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7692

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7692

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7692

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7692

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7692

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7692

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7692

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7692

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7692

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7692

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7692

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7692

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7692

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7692

commit: 4b82dff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants