Closed
Conversation
- separate out all base selector / element styles from _main_tags partial - remove unused styles - simplify rules when possible
- homepage sub-head text on first slide - buttons on homepage - headings on other pages
clhenrick
commented
Mar 26, 2025
app/src/scss/_base.scss
Outdated
| } | ||
| } | ||
|
|
||
| a { |
Owner
Author
There was a problem hiding this comment.
- use
a[href]as a selector here? - use
:where()to reduce selector specificity?
| li { | ||
| max-width: $normal-text-max-width; | ||
| line-height: $normal-text-line-height; | ||
| text-wrap: balance; |
Owner
Author
There was a problem hiding this comment.
is this needed if li children have this property?
| margin-left: auto; | ||
| margin-right: auto; | ||
| inset: $nav-main-height 0 0 0; | ||
| max-width: 960px; |
Owner
Author
There was a problem hiding this comment.
add a css variable for this?
app/src/scss/_utility-classes.scss
Outdated
Comment on lines
+23
to
+26
| /* TYPOGRAPHY */ | ||
| // TODO: clean up these util classes | ||
| // big header / title fonts on the home page | ||
| .font-style-hero { |
Owner
Author
There was a problem hiding this comment.
wondering if at least removing all the width variations might be possible now that text-wrap: balance is being used?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part one of (n) to clean up the project's CSS:
base.scsspartial to set base level element styles