Skip to content

docs(pkg/api): explain HandleHTTPError does not close response body #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
babakks merged 1 commit into from
Nov 3, 2025
Merged

docs(pkg/api): explain HandleHTTPError does not close response body #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/api/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ func matchPath(p, expect string) bool {
}

// HandleHTTPError parses a http.Response into a HTTPError.
//
// The function attempts to read the response's body, but it does not close it.
func HandleHTTPError(resp *http.Response) error {
httpError := &HTTPError{
Headers: resp.Header,
Expand Down
Loading