-
Notifications
You must be signed in to change notification settings - Fork 880
feat(layers): Graph and Paper embedding layers implementation #2908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Geliogabalus
wants to merge
54
commits into
clientIO:master
Choose a base branch
from
Geliogabalus:embedding-layers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 41 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
5ddbc5e
wip
Geliogabalus 724b1a8
wip
Geliogabalus 044af30
layer models
Geliogabalus af043f2
wip
Geliogabalus 60bbcd9
update
Geliogabalus 5832a22
fix
Geliogabalus bb09418
up
Geliogabalus 9a9aeac
up
Geliogabalus 6249685
up
Geliogabalus 1a208bc
up
Geliogabalus 309edaa
wip
Geliogabalus 099cf81
up
Geliogabalus 2f2c482
up
Geliogabalus 62ed851
wip
Geliogabalus 903e922
wip
Geliogabalus b491ea8
fix
Geliogabalus 1533570
up
Geliogabalus 0752076
up
Geliogabalus 163c221
wip
Geliogabalus c66280b
wip
Geliogabalus c2dc6ae
wip
Geliogabalus 0a2f047
up
Geliogabalus 8a03a89
up
Geliogabalus d058bac
reset fix
Geliogabalus 468a6c6
wip
Geliogabalus 5083b69
up
Geliogabalus dab0da8
update
Geliogabalus 58be262
up
Geliogabalus 15ec945
tests start
Geliogabalus e4786f2
fixes and tests
Geliogabalus 1487770
update
Geliogabalus bf9a4c8
wip
Geliogabalus 7864d01
update
Geliogabalus 4d8ed05
up
Geliogabalus 4152946
refactor
Geliogabalus 2c6c5d9
up
Geliogabalus 29ca501
revert
Geliogabalus ec9a33a
up
Geliogabalus 505fc50
up
Geliogabalus 6eb29f1
wip
Geliogabalus a94376e
async removing
Geliogabalus ed79f8e
wip (probably doesn't work)
Geliogabalus 8358fa8
up
Geliogabalus 5e4b02b
up
Geliogabalus 8328efe
wip
Geliogabalus 34812b6
up
Geliogabalus d861c35
fix
Geliogabalus 3c6aa1d
fix
Geliogabalus a852825
final
Geliogabalus 8782e66
typings
Geliogabalus b08e3ec
up
Geliogabalus 49f8a85
up
Geliogabalus c32030d
wip
Geliogabalus 57f18b0
update
Geliogabalus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -117,7 +117,7 @@ export const HighlighterView = mvc.View.extend({ | |
| vGroup = V('g').addClass('highlight-transform').append(el); | ||
| } | ||
| this.transformGroup = vGroup; | ||
| paper.getLayerView(layerName).insertSortedNode(vGroup.node, options.z); | ||
| paper.getLayer(layerName).insertSortedNode(vGroup.node, options.z); | ||
|
||
| } else { | ||
| // TODO: prepend vs append | ||
| if (!el.parentNode || el.nextSibling) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should accept
layerNamenow and not be deprecated