-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor to use variation-normalizer Python library #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ount and CopyNumberChange
This was referenced Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allele,CopyNumberCount,CopyNumberChangeto use methods in thevariation-normalizationcodeThis does change the prereqs for running this process.
The VICC-customized UTA must be used as it adds a table which is referenced in some operations by the
variation-normalizationcode. The compose.yaml below includes this and it includes a necessary gene-normalizer dynamodb server. Change the local ports as necessary to avoid collisions.https://github.com/cancervariants/variation-normalization/blob/0.15.0/compose.yaml
It also makes some changes to add an asyncio event loop to each worker process so they can execute calls into the async
variation-normalizationfunctions. A future feature here may be to update our code to use asyncio.