Fix dropped errors in manifold.go-off
#249
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeout tests are changed so that every timeout exception has a uniquely identifiable message which makes it easier to match up the dropped error warning with the originating timeout.
| (catch Throwable ex | ||
| (d/error! (async-runtime/aget-object state async-runtime/USER-START-IDX) ex) | ||
| (throw ex)))) | ||
| (d/error! (async-runtime/aget-object state async-runtime/USER-START-IDX) ex)))) |
There was a problem hiding this comment.
I haven't used this code in years, can't say I remember why we were re-throwing the original error
There was a problem hiding this comment.
Thanks for your reply! Alright, I'll try to get to the bottom of this myself then 💪
valerauko
reviewed
Sep 30, 2025
| (is (= ::timeout @(go-off (<!? (d/alt (d/deferred) (d/timeout! (d/deferred) 10 ::timeout)))))) | ||
| (is (= ::timeout @(d/alt (go-off (<!? (d/deferred))) (d/timeout! (d/deferred) 10 ::timeout)))) | ||
| (is (= ::timeout @(go-off (<!? (d/alt (d/deferred) (d/timeout! (d/deferred) 13 ::timeout)))))) | ||
| (is (= ::timeout @(d/alt (go-off (<!? (d/deferred))) (d/timeout! (d/deferred) 14 ::timeout)))) |
There was a problem hiding this comment.
why is this change necessary?
| (try (async-runtime/run-state-machine state) | ||
| (catch Throwable ex | ||
| (d/error! (async-runtime/aget-object state async-runtime/USER-START-IDX) ex) | ||
| (throw ex)))) |
There was a problem hiding this comment.
was this rethrow the core of the issue?
since you're catching the extremely wide Throwable it'd feel safer to keep the rethrow unless that's what's causing the problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeout tests are changed so that every timeout exception has a uniquely identifiable message which makes it easier to match up the dropped error warning with the originating timeout.
Based on #248. Fixes the remaining dropped error failure in
manifold.go-off-test.@tanzoniteblack Sine you're the original author of
manifold.go-off, maybe you could review this one? 🙏 I'm not quite sure whether not re-throwing the exception here breaks anything else, and if it should, maybe you could provide a test case? It definitely does lead to an unhandled deferred in error state, though, as evidenced by the test failure without the patch. However, I don't even grok which deferred that is 😅