Skip to content

test & dev: maint #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

test & dev: maint #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7601195
test libs: re-enable refactor-nrepl
lread May 6, 2025
9893199
dev: bump deps
lread May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/libs-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,10 @@ jobs:
clj-cache-prefix: clj-libs-deps-${{ matrix.lib-name }}
clj-cache-hash-files: "'script/test_libs.clj','deps.edn','bb.edn'"

## Lein version > 2.10.0 is causing refactor-nrepl to fail, so explicitly install a version that works
## instead of using lein bundled with github actions image.
## Upcoming 2.11.2 might fix, can optionally revisit in the future.
- name: Install Lein
uses: DeLaGuardo/[email protected]
with:
lein: 2.10.0
lein: 2.11.2

- name: Install Planck
uses: ./.github/workflows/setup-planck
Expand Down
5 changes: 2 additions & 3 deletions deps.edn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@
{;; for disabling the official compiler
:classpath-overrides {org.clojure/clojure nil}
:extra-deps {com.github.flow-storm/clojure {:mvn/version "1.12.0-9"}
com.github.flow-storm/flow-storm-dbg {:mvn/version "4.4.0"}}
com.github.flow-storm/flow-storm-dbg {:mvn/version "4.4.1"}}
:jvm-opts ["-Dclojure.storm.instrumentEnable=true"]}

:nrepl/jvm
{:extra-deps {refactor-nrepl/refactor-nrepl {:mvn/version "3.10.0"}}
{:extra-deps {refactor-nrepl/refactor-nrepl {:mvn/version "3.11.0"}}
:jvm-opts ["-Djdk.attach.allowAttachSelf"]
:main-opts ["-m" "nrepl.cmdline"
"--middleware" "[refactor-nrepl.middleware/wrap-refactor cider.nrepl/cider-middleware]"
Expand Down Expand Up @@ -180,5 +180,4 @@
"--exclude=org.clojure/[email protected]" ;; no evidence yet that this is an official release
"--exclude=technomancy/[email protected]" ;; exclude for refactor-nrepl lib test
"--exclude=technomancy/[email protected]" ;; exclude for refactor-nrepl lib test
"--exclude=technomancy/[email protected]" ;; exclude for refactor-nrepl lib test
]}}}
8 changes: 3 additions & 5 deletions script/test_libs.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,7 @@
;;
;; refactor-nrepl
;;
;; uncomment we we re-enable
#_(defn- refactor-nrepl-patch
(defn- refactor-nrepl-patch
"custom because my generic does not handle ^:inline-dep syntax"
[{:keys [home-dir rewrite-clj-version]}]
(status/line :detail "=> Patching deps")
Expand Down Expand Up @@ -420,9 +419,8 @@
:patch-fn deps-edn-v1-patch
:show-deps-fn cli-deps-tree
:test-cmds ["clojure -M:test"]}
;; temporarily disable, see https://github.com/clojure-emacs/refactor-nrepl/issues/409
#_{:name "refactor-nrepl"
:version "3.10.0"
{:name "refactor-nrepl"
:version "3.11.0"
:platforms [:clj]
:github-release {:repo "clojure-emacs/refactor-nrepl"
:via :tag
Expand Down