Make Timestamp, TimeDuration,Vec<u8> implement FilterableValue #3008
+658
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
added
enhancement
mamcx
force-pushed
the
mamcx/filterable-timestamp-duration-bytes
branch
2 times, most recently
from
390f24c to
0c0e262
Compare
jsdt
reviewed
Aug 1, 2025
| /** | ||
| * Compares the current instance with another object of the same type. | ||
| */ | ||
| interface Comparable<T> { |
There was a problem hiding this comment.
What are the implications of being a filterable value?
It means a Filter functions is generated for this field, but you can filter with sql any field.
There was a problem hiding this comment.
Is this used?
Is removed now, was before agreement to not mirror yet the filterable trait
rekhoff
reviewed
Aug 1, 2025
| @@ -1,6 +1,8 @@ | |||
| use crate::{ConnectionId, Identity}; | |||
| use core::ops; | |||
| use spacetimedb_sats::bsatn; | |||
| use spacetimedb_sats::time_duration::TimeDuration; | |||
| use spacetimedb_sats::timestamp::Timestamp; | |||
| use spacetimedb_sats::{hash::Hash, i256, u256, Serialize}; | |||
|
|
|||
| /// Types which can appear as an argument to an index filtering operation | |||
There was a problem hiding this comment.
We should probably add Timestamp and TimeDuration to the of types specifically called out as having corresponding FilterableValue implementations in this comment block.
rekhoff
reviewed
Aug 1, 2025
| @@ -171,6 +171,18 @@ public partial struct Player | |||
| public string name; | |||
| } | |||
|
|
|||
| // Extra table for checking implementation of `FilterableValue` trait | |||
There was a problem hiding this comment.
If we are adding a table to specifically check for the FilterableValue trait, we should add the other filterable types as well.
mamcx
force-pushed
the
mamcx/filterable-timestamp-duration-bytes
branch
2 times, most recently
from
4e53b8a to
e190de1
Compare
mamcx
force-pushed
the
mamcx/filterable-timestamp-duration-bytes
branch
from
e190de1 to
4c9c51f
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
As the title says.
Closes #2650
Expected complexity level and risk
1
Testing
NOTE : Need input in what other testing to add
Comparablein theC#side