Skip to content

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Aug 8, 2025

Description of Changes

Migrating clockworklabs/com.clockworklabs.spacetimedbsdk#277 since we are merging that repo into this one.

Adds a test to com.clockworklabs.spacetimedbsdk that checks if the BTreeIndexBase class Column implements the IComparable interface. This is the implementation side of issue #2362.

API and ABI breaking changes

  • This is an API breaking change to the SDK

Expected complexity level and risk

Testing

  • Ran dotnet test, all checks pass.

{
Identity = new(this);
}
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding comment from the other PR:

This code won't catch problems that occur if the code generation changes in the future. To catch such problems, we'd need to write the same test against generated code. For example, we could add an index to the Message.Sender field in quickstart-chat -- these tests have access to the quickstart-chat generated code.

If you want to do that, it would be great; if not, I'm willing to merge this, but would appreciate a comment saying why this class is here. // Copy of generated code for a BTreeIndex; TODO: update if that code changes is messy but at least documents what is going on.

@bfops bfops added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no runtime change This change does not affect the final binaries release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants