Skip to content

C#/Unity SDK - Batch index updates #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: csharp/jgilles/pre_hashed_row
Choose a base branch
from

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Aug 8, 2025

Description of Changes

Migrating clockworklabs/com.clockworklabs.spacetimedbsdk#336 since we are merging that repo into this one.

Rearranges some loops so that each row doesn't have to make a bunch of indirect function calls to update indexes.

API and ABI breaking changes

None

Expected complexity level and risk

Testing

  • Walked around in BitCraft
  • Full BitCraft tutorial

@bfops
Copy link
Collaborator Author

bfops commented Aug 8, 2025

@rekhoff The original PR was approved - do you know of any reason that we shouldn't merge this?

Edit: Actually, I realize now that this isn't based on master.. and I think we were unsure about whether to merge the base branch. I would love your thoughts on the best way to move forward here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants