C#/Unity SDK - Pre-hash rows and add SmallHashSets

sdks/csharp/examples~/regression-tests/client/Program.cs

@@ -83,7 +83,8 @@ void ValidateBTreeIndexes(IRemoteDbContext conn)
     Log.Debug("Checking indexes...");
     foreach (var data in conn.Db.ExampleData.Iter())
     {
-        Debug.Assert(conn.Db.ExampleData.Indexed.Filter(data.Id).Contains(data));
+        Log.Debug($"{data}: [{string.Join(", ", conn.Db.ExampleData.Indexed.Filter(data.Indexed))}]");
+        Debug.Assert(conn.Db.ExampleData.Indexed.Filter(data.Indexed).Contains(data));
     }
     var outOfIndex = conn.Db.ExampleData.Iter().ToHashSet();
 
@@ -107,10 +108,38 @@ void OnSubscriptionApplied(SubscriptionEventContext context)
     waiting++;
     context.Reducers.Add(1, 1);
 
+    Log.Debug("Calling Add");
+    waiting++;
+    context.Reducers.Add(2, 1);
+
+    Log.Debug("Calling Add");
+    waiting++;
+    context.Reducers.Add(3, 1);
+
+    Log.Debug("Calling Add");
+    waiting++;
+    context.Reducers.Add(4, 2);
+
+    Log.Debug("Calling Add");
+    waiting++;
+    context.Reducers.Add(6, 2);
+
+    Log.Debug("Calling Add");
+    waiting++;
+    context.Reducers.Add(5, 2);
+
     Log.Debug("Calling Delete");
     waiting++;
     context.Reducers.Delete(1);
 
+    Log.Debug("Calling Delete");
+    waiting++;
+    context.Reducers.Delete(2);
+
+    Log.Debug("Calling Delete");
+    waiting++;
+    context.Reducers.Delete(3);
+
     Log.Debug("Calling Add");
     waiting++;
     context.Reducers.Add(1, 1);

sdks/csharp/src/MultiDictionary.cs

@@ -18,6 +18,7 @@ namespace SpacetimeDB
     /// <typeparam name="TKey"></typeparam>
     /// <typeparam name="TValue"></typeparam>
     internal struct MultiDictionary<TKey, TValue> : IEquatable<MultiDictionary<TKey, TValue>>
+    where TValue : struct
     {
         // The actual data.
         readonly Dictionary<TKey, (TValue Value, uint Multiplicity)> RawDict;
@@ -66,10 +67,6 @@ public static MultiDictionary<TKey, TValue> FromEnumerable(IEnumerable<KeyValueP
         /// <returns>Whether the key is entirely new to the dictionary. If it was already present, we assert that the old value is equal to the new value.</returns>
         public bool Add(TKey key, TValue value)
         {
-            if (value == null)
-            {
-                throw new NullReferenceException("Null values are forbidden in multidictionary");
-            }
             Debug.Assert(RawDict != null);
             Debug.Assert(key != null);
             if (RawDict.TryGetValue(key, out var result))
@@ -362,6 +359,7 @@ public override string ToString()
     /// <typeparam name="TKey"></typeparam>
     /// <typeparam name="TValue"></typeparam>
     internal struct MultiDictionaryDelta<TKey, TValue> : IEquatable<MultiDictionaryDelta<TKey, TValue>>
+    where TValue : struct
     {
         /// <summary>
         /// A change to an individual value associated to a key.
@@ -638,10 +636,6 @@ public MultiDictionaryDelta(IEqualityComparer<TKey> keyComparer, IEqualityCompar
         /// <param name="item"></param>
         public void Add(TKey key, TValue value)
         {
-            if (value == null)
-            {
-                throw new NullReferenceException("Null values are forbidden in multidictionary");
-            }
             Debug.Assert(RawDict != null);
             Debug.Assert(key != null);
             KeyDelta result;