V8: Define and test call_describe_module
#3161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/describe-module
branch
2 times, most recently
from
36e9236 to
8fc0e4e
Compare
Centril
force-pushed
the
centril/describe-module
branch
from
8fc0e4e to
654169b
Compare
gefjon
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Defines a building piece
call_describe_modulethat can be used to call the expected ABI functiondescribe_modulein JS.There might be further changes to this but this is a first working pass at it.
API and ABI breaking changes
None
Expected complexity level and risk
2, this does not integrate with existing code reachable in production, but the exception handling required some googling/reading docs.
Testing
A test
call_describe_module_worksis added that tests returning an emptyRawModuleDeffrom JS.