fixup - code-buffer=>source-buffer

Author: alexander-yakushev

cider-eval.el

@@ -350,10 +350,10 @@ https://clojure.org/reference/repl_and_main#_at_repl"
                                               (save-excursion (end-of-line) (point))
                                               'cider-error-overlay-face))))
 
-(defun cider--handle-stacktrace-response (causes ex-phase code-buffer)
+(defun cider--handle-stacktrace-response (causes ex-phase source-buffer)
   "Handle stacktrace response provided as aggregated CAUSES.
 For EX-PHASE that represents compilation errors, don't show *cider-error*
-buffer but render an error overlay instead in the CODE-BUFFER.
+buffer but render an error overlay instead in the SOURCE-BUFFER.
 For others, pop up *cider-error* buffer."
   ;; Handle special "notification" server messages.
   (dolist (cause causes)
@@ -366,9 +366,10 @@ For others, pop up *cider-error* buffer."
   ;; If the error is a compilation error (which we normally don't show
   ;; *cider-error* buffer for), or the error buffer is disabled, compensate for
   ;; the lack of info with a overlay error. Verify that the provided buffer is
-  ;; visiting a source file.
-  (when (and code-buffer
-             (with-current-buffer code-buffer
+  ;; not a REPL buffer but either visits a Clojure source file or is
+  ;; e.g. cider-scratch.
+  (when (and source-buffer
+             (with-current-buffer source-buffer
                (or (cider-clojure-major-mode-p)
                    (cider-clojurec-major-mode-p)
                    (cider-clojurescript-major-mode-p)))
@@ -383,7 +384,7 @@ For others, pop up *cider-error* buffer."
            (err-message (if triage
                             (concat err-message "\n" triage)
                           err-message)))
-      (cider--display-error-unobtrusively code-buffer err-message))))
+      (cider--display-error-unobtrusively source-buffer err-message))))
 
 (defun cider--analyze-last-stacktrace (callback)
   "Send `analyze-last-stacktrace' to server and invoke CALLBACK on the result.