Conversation
One has to use structural movements in order to present the overlay without errors. By using this finer-grained function, it's more likely that the overlay will show at the right place (and not too far away at the bottom).
|
|
||
| With a double prefix argument, or if MODE is `clear', clear the state of | ||
| the namespace tracker before reloading. This is useful for recovering from | ||
| With a double prefix argument, or if MODE is `clear' (or `clear-and-inhibit'), |
There was a problem hiding this comment.
Probably we'll need to document this somewhere in the manual as well, otherwise few people are going to find it.
There was a problem hiding this comment.
Sure. While we're here, should the new mode be invokable through some prefix incantation?
tbh I don't use prefixes at all so I wouldn't know how to add a new variation here.
There was a problem hiding this comment.
That would be nice indeed. I think multiple prefixes had to be checked as some number value in the code to differentiate them. There must be some examples in the code. I do think, however, we should start moving towards transient for prefix arguments as it's UI is so much better, and it's bundled with Emacs 28+.
There was a problem hiding this comment.
I expanded the user manual
I do think, however, we should start moving towards transient for prefix arguments as it's UI is so much better
In face of this maybe we can refrain from doubling down on prefixes (at least here).
Transient rocks and would love to see a few features / examples of how it would look for CIDER
vemv
left a comment
vemv
left a comment
There was a problem hiding this comment.
Ready again with a cider--semantic-end-of-line which seems to do the right thing
|
|
||
| With a double prefix argument, or if MODE is `clear', clear the state of | ||
| the namespace tracker before reloading. This is useful for recovering from | ||
| With a double prefix argument, or if MODE is `clear' (or `clear-and-inhibit'), |
There was a problem hiding this comment.
I expanded the user manual
I do think, however, we should start moving towards transient for prefix arguments as it's UI is so much better
In face of this maybe we can refrain from doubling down on prefixes (at least here).
Transient rocks and would love to see a few features / examples of how it would look for CIDER
| @@ -1,4 +1,5 @@ | |||
| edn | |||
| fo | |||
There was a problem hiding this comment.
Why so? That's often a misspelled of.
|
I'll take a closer look tomorrow. |
| menu-list)) | ||
|
|
||
| (defun cider--semantic-end-of-line () | ||
| "Returns POINT at the closest EOL that we can move to semantically, |
There was a problem hiding this comment.
I'm not sure I understand this. What's an EOL to which we can move semantically? I checked the tests as well, but all assertions are in a single tests, so it's pretty hard to figure out what you're testing for exactly.
| classpath. | ||
|
|
||
| Adding a prefix argument, kbd:[C-u C-c M-n r], will reload all | ||
| Adding a prefix argument, kbd:[C-u C-c M-n r], it will reload all |
There was a problem hiding this comment.
I think "Adding" is not the right terminology here, which affects the rest of the sentence (which reads a bit awkwardly to me). I'd write something like "If you invoke cider-ns-refresh with a prefix argument it will" or something along those lines.
|
Ping :-) |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed soon if no further activity occurs. Thank you for your contribution and understanding! |
2 participants
cider-ns--present-errorcider-ns--present-error: preferend-of-sexpcider-ns-refresh: acceptclear-and-inhibitmodeclearing.Cheers - V