Skip to content

[completion] Use ignore instead of try-completion-function in CIDER completion style #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[completion] Use ignore instead of try-completion-function in CIDER completion style #3750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions cider-completion.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,14 +256,6 @@ in the buffer."

;; Fuzzy completion for company-mode

(defun cider-completion-try-completion (string collection pred _)
"Return longest common substring of all completions of STRING in COLLECTION,
also pass PRED to `try-completion'.

This function is only needed to be a correct citizen in
`completion-styles-alist'."
(try-completion string collection pred))

(defun cider-company-unfiltered-candidates (string &rest _)
"Return CIDER completion candidates for STRING as is, unfiltered."
(cider-complete string))
Expand All @@ -276,7 +268,8 @@ This function is only needed to be a correct citizen in
;; which introduced `cider-company-enable-fuzzy-completion')
(add-to-list 'completion-styles-alist
'(cider
cider-completion-try-completion
;; Use `ignore' in place of "try-competion function".
ignore
cider-company-unfiltered-candidates
"CIDER backend-driven completion style."))

Expand Down
Loading