Show spinner in mode line while tests are running#3867
Merged
Conversation
The spinner settings are now used for both eval and test operations, so the eval-specific names no longer make sense. - cider-eval-spinner-type -> cider-spinner-type - cider-show-eval-spinner -> cider-show-spinner - cider-eval-spinner-delay -> cider-spinner-delay Old names kept as obsolete aliases.
Reuses the existing spinner infrastructure from cider-client.el. The spinner starts when tests are dispatched and stops when results arrive (or on error/not-found).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3645.
Shows a mode line spinner while tests are running, reusing the existing spinner infrastructure from
cider-client.el. Also renames the eval-specific spinner defcustoms (cider-eval-spinner-type,cider-show-eval-spinner,cider-eval-spinner-delay) to generic names (cider-spinner-type,cider-show-spinner,cider-spinner-delay) since they now control spinners for both eval and test operations. Old names are kept as obsolete aliases.