Skip to content

CLJS-3418: Some Closure libraries are not lowered because they declare es8 (instead of just es6) in deps.js for Google Closure Library #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024
Merged

CLJS-3418: Some Closure libraries are not lowered because they declare es8 (instead of just es6) in deps.js for Google Closure Library #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/clojure/cljs/closure.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@

(def lang-level
[:ecmascript3 :ecmascript5 :ecmascript5-strict :ecmascript6 :ecmascript6-strict
:ecmascript8
:ecmascript-2015 :ecmascript-2016 :ecmascript-2017 :ecmascript-2018
:ecmascript-2019 :ecmascript-2020 :ecmascript-2021 :ecmascript-next
:no-transpile])
Expand All @@ -251,6 +252,7 @@
:ecmascript5-strict CompilerOptions$LanguageMode/ECMASCRIPT5_STRICT
:ecmascript6 CompilerOptions$LanguageMode/ECMASCRIPT_2015 ;; (deprecated and remapped)
:ecmascript6-strict CompilerOptions$LanguageMode/ECMASCRIPT_2015 ;; (deprecated and remapped)
:ecmasscript8 CompilerOptions$LanguageMode/ECMASCRIPT_2017
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed thanks!

:ecmascript-2015 CompilerOptions$LanguageMode/ECMASCRIPT_2015
:ecmascript-2016 CompilerOptions$LanguageMode/ECMASCRIPT_2016
:ecmascript-2017 CompilerOptions$LanguageMode/ECMASCRIPT_2017
Expand Down
Loading