Skip to content

CLJS-3242: trailing keys bug #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2025
Merged

CLJS-3242: trailing keys bug #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0798a5d
CLJS-3242: trailing keys bug
swannodette Jan 8, 2025
c87df98
fix test
swannodette Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/cljs/cljs/core.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7217,7 +7217,7 @@ reduces them without incurring seq initialization"
(let [kv (first extra-kvs)]
(aset ret i (-key kv))
(aset ret (inc i) (-val kv))
(recur (+ 2 seed-cnt) (next extra-kvs)))
(recur (+ 2 i) (next extra-kvs)))
ret))))

(set! (.-createAsIfByAssoc PersistentArrayMap)
Expand Down
6 changes: 3 additions & 3 deletions src/test/cljs/cljs/core_test.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2043,10 +2043,10 @@
(is (= [11 0] (reset-vals! c 0)))
(is (= 0 @c)))))

#_(defn test-keys [& {:as opts, :keys [a b]}]
(defn test-keys [& {:as opts, :keys [a b]}]
[a b opts])

#_(deftest test-cljs-3299-trailing-keys
(deftest test-cljs-3299-trailing-keys
(testing "verify proper handling of trailing keys"
(is (= (test-keys :a 1, :b 2)
[1 2 {:a 1, :b 2}]))
Expand All @@ -2055,4 +2055,4 @@
(is (= (test-keys {:a 1, :b 2, :c 3})
[1 2 {:a 1, :b 2, :c 3}]))
(is (= (test-keys :d 4 {:a 1, :b 2, :c 3})
[1 nil {:d 4, :a 1, :c 3, nil nil}]))))
[1 2 {:d 4, :a 1, :b 2, :c 3}]))))
Loading