Open
Conversation
naxels
commented
Nov 19, 2022
naxels
commented
- Update DCD 2022 to Archive since it happened
- Removed the slashes in front of the hashes in href, in order to make the links work on each page, instead of being redirected back to main if you are on an older edition page
- Small update to the hamburger logo to exclude it from the Skyscraper example we are creating, however keeping the styling & working as expected. (see my note in the commit on my belief about .item on the hamburger)
So they work on each DCD page, not turning you back to index
Remove .item for improving parsing in the Skyscraper side project and I believe it should be treated differently than a .item since it's only there for smaller screensizes with a special purpose different from other sidebar elements. during testing I haven't been able to break this small change on macOS & iOS devices.
|
so this one is a bit of a pickle. I think the proper "archiving" procedure should be:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.